You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here, the wfpt_reg_like function is defined with sampling_method="cssm". This setting is hardcoded and cannot be modified during model definition, leading to PPC errors in specific scenarios. In contrast, the default sampling_method="drift" does not result in such issues in the version of hddm 0.8.0, see InferenceData (.nc file) not generated for HDDMRegression with stimulus coding.
Steps to Reproduce:
Fit a regression model using stimcoding as a regressor with the current HDDM version (>=1.0.0).
Perform PPC analysis, which reveals errors due to the fixed sampling_method="cssm".
Suggested Fix:
We recommend allowing users to configure the sampling_method parameter during model definition to override the hardcoded sampling_method="cssm". Alternatively, reverting to the default sampling_method="drift" may resolve the PPC errors.
The text was updated successfully, but these errors were encountered:
Problem Description:
We identified an issue in the
hddm_regression
module where the fixedsampling_method="cssm"
parameter causes PPC (Posterior Predictive Check) errors in dockerHDDM InferenceData (.nc file) not generated for HDDMRegression with stimulus coding.Specifically, the problem arises in the following line of code:
https://github.com/hddm-devs/hddm/blob/6e766ef315629c20cd0be7267555c90c39cc0446/hddm/models/hddm_regression.py#L130
Here, the
wfpt_reg_like
function is defined withsampling_method="cssm"
. This setting is hardcoded and cannot be modified during model definition, leading to PPC errors in specific scenarios. In contrast, the defaultsampling_method="drift"
does not result in such issues in the version of hddm 0.8.0, see InferenceData (.nc file) not generated for HDDMRegression with stimulus coding.Steps to Reproduce:
stimcoding
as a regressor with the current HDDM version (>=1.0.0).sampling_method="cssm"
.Suggested Fix:
We recommend allowing users to configure the
sampling_method
parameter during model definition to override the hardcodedsampling_method="cssm"
. Alternatively, reverting to the defaultsampling_method="drift"
may resolve the PPC errors.The text was updated successfully, but these errors were encountered: