Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility issues with Kabuki] Issue with Fixed sampling_method="cssm" Causing PPC Errors in HDDM Regression Models #119

Open
panwanke opened this issue Nov 20, 2024 · 0 comments

Comments

@panwanke
Copy link

Problem Description:

We identified an issue in the hddm_regression module where the fixed sampling_method="cssm" parameter causes PPC (Posterior Predictive Check) errors in dockerHDDM InferenceData (.nc file) not generated for HDDMRegression with stimulus coding.

Specifically, the problem arises in the following line of code: https://github.com/hddm-devs/hddm/blob/6e766ef315629c20cd0be7267555c90c39cc0446/hddm/models/hddm_regression.py#L130

Here, the wfpt_reg_like function is defined with sampling_method="cssm". This setting is hardcoded and cannot be modified during model definition, leading to PPC errors in specific scenarios. In contrast, the default sampling_method="drift" does not result in such issues in the version of hddm 0.8.0, see InferenceData (.nc file) not generated for HDDMRegression with stimulus coding.


Steps to Reproduce:

  1. Fit a regression model using stimcoding as a regressor with the current HDDM version (>=1.0.0).
  2. Perform PPC analysis, which reveals errors due to the fixed sampling_method="cssm".

Suggested Fix:

We recommend allowing users to configure the sampling_method parameter during model definition to override the hardcoded sampling_method="cssm". Alternatively, reverting to the default sampling_method="drift" may resolve the PPC errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant