From c954ff11ad904e8e98e3a542011ff1c4445c07e9 Mon Sep 17 00:00:00 2001 From: Tim 'mithro' Ansell Date: Tue, 3 Oct 2023 19:18:56 -0700 Subject: [PATCH 1/3] Buildifier fix for vivado/defs.bzl. Signed-off-by: Tim 'mithro' Ansell --- vivado/defs.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vivado/defs.bzl b/vivado/defs.bzl index be481703..f2faf0a9 100644 --- a/vivado/defs.bzl +++ b/vivado/defs.bzl @@ -653,7 +653,7 @@ vivado_write_bitstream = rule( ], ) -def vivado_flow(name, module, module_top, part_number, xilinx_env, tags = [], ip_blocks = [], with_xsa=False): +def vivado_flow(name, module, module_top, part_number, xilinx_env, tags = [], ip_blocks = [], with_xsa = False): """Runs the entire bitstream flow as a convenience macro. Args: From 703c827ea74b2aa9206986b5c4acf0a912507304 Mon Sep 17 00:00:00 2001 From: Tim 'mithro' Ansell Date: Tue, 3 Oct 2023 19:19:22 -0700 Subject: [PATCH 2/3] Buildifier fix for com_google_gooletest Signed-off-by: Tim 'mithro' Ansell --- .../com_google_googletest/com_google_googletest.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dependency_support/com_google_googletest/com_google_googletest.bzl b/dependency_support/com_google_googletest/com_google_googletest.bzl index c4bcc6f0..8ae9f52c 100644 --- a/dependency_support/com_google_googletest/com_google_googletest.bzl +++ b/dependency_support/com_google_googletest/com_google_googletest.bzl @@ -21,7 +21,7 @@ def com_google_googletest(): maybe( http_archive, name = "com_google_googletest", - urls = ["https://github.com/google/googletest/archive/refs/tags/v1.14.0.zip"], # Release 2nd Aug 2023 + urls = ["https://github.com/google/googletest/archive/refs/tags/v1.14.0.zip"], # Release 2nd Aug 2023 strip_prefix = "googletest-1.14.0", sha256 = "1f357c27ca988c3f7c6b4bf68a9395005ac6761f034046e9dde0896e3aba00e4", ) From 15d10e9681fd68423eb21dc59ea7f0b8c001f35b Mon Sep 17 00:00:00 2001 From: Tim 'mithro' Ansell Date: Tue, 3 Oct 2023 19:18:14 -0700 Subject: [PATCH 3/3] Buildifier fixes to place_and_route files. Signed-off-by: Tim 'mithro' Ansell --- place_and_route/build_defs.bzl | 4 ++-- place_and_route/private/global_placement.bzl | 2 +- place_and_route/private/place_pins.bzl | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/place_and_route/build_defs.bzl b/place_and_route/build_defs.bzl index 8cd22640..0f257b2a 100644 --- a/place_and_route/build_defs.bzl +++ b/place_and_route/build_defs.bzl @@ -103,7 +103,7 @@ place_and_route = rule( "placement_density": attr.string(default = "0.69", doc = "When performing global placement this is how densely our cells should be packaged on the die parameter is (0-1]"), "density_fill_config": attr.label(allow_single_file = True), "sink_clustering_size": attr.int(doc = "Clock tree synthesis sink group size"), - "sink_clustering_max_diameter": attr.int(doc = "Clock tree synthesis sink group desired diamater in microns"), - "min_pin_distance": attr.string(doc = "The minimum distance in microns between pins around the outside of the block."), + "sink_clustering_max_diameter": attr.int(doc = "Clock tree synthesis sink group desired diamater in microns"), + "min_pin_distance": attr.string(doc = "The minimum distance in microns between pins around the outside of the block."), }, ) diff --git a/place_and_route/private/global_placement.bzl b/place_and_route/private/global_placement.bzl index bb654c60..15185032 100644 --- a/place_and_route/private/global_placement.bzl +++ b/place_and_route/private/global_placement.bzl @@ -40,7 +40,7 @@ def global_placement(ctx, open_road_info): pad_left = open_road_configuration.global_placement_cell_pad, pad_right = open_road_configuration.global_placement_cell_pad, ), - "remove_buffers", + "remove_buffers", ] command_output = openroad_command( diff --git a/place_and_route/private/place_pins.bzl b/place_and_route/private/place_pins.bzl index c6b16155..a20bcc81 100644 --- a/place_and_route/private/place_pins.bzl +++ b/place_and_route/private/place_pins.bzl @@ -55,7 +55,7 @@ def place_pins(ctx, open_road_info): hor_layers = open_road_configuration.pin_horizontal_metal_layer, ver_layers = open_road_configuration.pin_vertical_metal_layer, min_pin_distance = "-min_distance {}".format(ctx.attr.min_pin_distance) if ctx.attr.min_pin_distance else "", - ), + ), tapcell_command, ]