Skip to content

Commit

Permalink
Added incompatibility flag to prepare for flip in future Bazel versions
Browse files Browse the repository at this point in the history
  • Loading branch information
abrisco committed Aug 6, 2024
1 parent 14d8a36 commit d4c4cbf
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ test:ciremotebuild --tls_client_key=/root/.ssh/buildbuddy-key.pem
test:ciremotebuild --build_metadata=VISIBILITY=PUBLIC
test:ciremotebuild --remote_timeout=3600

###############################################################################
## Incompatibility flags
###############################################################################

# https://github.com/bazelbuild/bazel/issues/8195
build --incompatible_disallow_empty_glob=true

###############################################################################
## User flags
###############################################################################
Expand Down
13 changes: 13 additions & 0 deletions dependency_support/org_gnu_bison/bison_empty_glob.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/bison/internal/gnulib/gnulib.BUILD b/bison/internal/gnulib/gnulib.BUILD
index 9ee0b51..84fcf5e 100644
--- a/bison/internal/gnulib/gnulib.BUILD
+++ b/bison/internal/gnulib/gnulib.BUILD
@@ -118,7 +118,7 @@ _GNULIB_SRCS = glob([
"lib/xmalloc.c",
"lib/xmemdup0.c",
"lib/xstrndup.c",
-])
+], allow_empty = True)

_GNULIB_DARWIN_SRCS = []

5 changes: 5 additions & 0 deletions dependency_support/org_gnu_bison/org_gnu_bison.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,9 @@ def org_gnu_bison():
name = "rules_bison",
sha256 = "2279183430e438b2dc77cacd7b1dbb63438971b2411406570f1ddd920b7c9145",
urls = ["https://github.com/jmillikin/rules_bison/releases/download/v0.2.2/rules_bison-v0.2.2.tar.xz"],
patch_args = ["-p1"],
patches = [
# TODO(https://github.com/jmillikin/rules_bison/pull/14): Delete after this PR is merged
Label("//dependency_support/org_gnu_bison:bison_empty_glob.patch"),
],
)

0 comments on commit d4c4cbf

Please sign in to comment.