From e2da0d949a872898de973dc24bd4551a0553bb62 Mon Sep 17 00:00:00 2001 From: Tim 'mithro' Ansell Date: Sun, 12 Nov 2023 11:10:02 -0800 Subject: [PATCH] Adding `toolchain=None` to `ctx.actions.run` targets. Fixes the following issue (and similar in `bazel_rules_hdl/place_and_route/open_road.bzl`) ``` tansell@tansell-top:/XXX/google3$ blaze build //third_party/bazel_rules_hdl/synthesis/tests:verilog_counter-asap7-sc7p5t_rev28_lvt-place_and_route ERROR: /XXX/google3/third_party/bazel_rules_hdl/synthesis/tests/BUILD:98:14: in synthesize_rtl rule //third_party/bazel_rules_hdl/synthesis/tests:verilog_counter-asap7-sc7p5t_rev28_lvt-synth: Traceback (most recent call last): File "/XXX/google3/third_party/bazel_rules_hdl/synthesis/build_defs.bzl", line 144, column 20, in _synthesize_design_impl ctx.actions.run( Error in run: Couldn't identify if tools are from implicit dependencies or a toolchain. Please set the toolchain parameter. If you're not using a toolchain, set it to 'None'. ERROR: /XXX/google3/third_party/bazel_rules_hdl/synthesis/tests/BUILD:98:14: Analysis of target '//third_party/bazel_rules_hdl/synthesis/tests:verilog_counter-asap7-sc7p5t_rev28_lvt-synth' failed ERROR: Analysis of target '//third_party/bazel_rules_hdl/synthesis/tests:verilog_counter-asap7-sc7p5t_rev28_lvt-place_and_route' failed; build aborted: Analysis failed INFO: Elapsed time: 0.198s, Critical Path: 0.01s, Remote (0.00% of the time): [queue: 0.00%, setup: 0.00%, process: 0.00%] ERROR: Build did NOT complete successfully ``` Signed-off-by: Tim 'mithro' Ansell --- place_and_route/open_road.bzl | 1 + static_timing/build_defs.bzl | 1 + synthesis/build_defs.bzl | 1 + 3 files changed, 3 insertions(+) diff --git a/place_and_route/open_road.bzl b/place_and_route/open_road.bzl index 5af6a26e..8a3b9e59 100644 --- a/place_and_route/open_road.bzl +++ b/place_and_route/open_road.bzl @@ -259,6 +259,7 @@ def openroad_command(ctx, commands, input_db = None, step_name = None, inputs = }, execution_requirements = execution_requirements, mnemonic = "OpenROAD", + toolchain = None, ) return struct(db = output_db, log_file = log_file) diff --git a/static_timing/build_defs.bzl b/static_timing/build_defs.bzl index 0bdcc25b..a03fd273 100644 --- a/static_timing/build_defs.bzl +++ b/static_timing/build_defs.bzl @@ -54,6 +54,7 @@ def _run_opensta_impl(ctx): input_manifests = input_manifests, env = env, mnemonic = "RunningSTA", + toolchain = None, ) return [ diff --git a/synthesis/build_defs.bzl b/synthesis/build_defs.bzl index 383acae4..c110efbe 100644 --- a/synthesis/build_defs.bzl +++ b/synthesis/build_defs.bzl @@ -150,6 +150,7 @@ def _synthesize_design_impl(ctx): input_manifests = input_manifests, env = env, mnemonic = "SynthesizingRTL", + toolchain = None, ) return [