Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting ready for bzlmod #336

Open
hzeller opened this issue Jun 29, 2024 · 6 comments
Open

Getting ready for bzlmod #336

hzeller opened this issue Jun 29, 2024 · 6 comments

Comments

@hzeller
Copy link
Collaborator

hzeller commented Jun 29, 2024

It would be good to get bazel_ruloes_hdl ready for bzlmod and add a MODULE.bazel.

https://bazel.build/external/migration

The oldest currently still maintained bazel 5 (and that can only work with old-school WORKSPACE ) is on the way out at the end of the year , bazel 6 allows to have bzlmod enabled and bazel 7 enables it by default.

@MaxwellBo
Copy link
Contributor

Are there any updates here? I'm finding it very painful to use this with modules and would appreciate some guidance on the correct approach to do so in the interim.

@hovind
Copy link
Collaborator

hovind commented Feb 21, 2025

I have done some experimenting over at main...hovind:bazel_rules_hdl:bzlmod/bazel-8, in case it is useful for anyone. bazelisk test ... passes, but it's far from "production quality".

@hzeller
Copy link
Collaborator Author

hzeller commented Feb 21, 2025

Nice! I also started working on the first small steps towards it. But if you're working on it: do you plan to make a PR, @hovind ?

@hovind
Copy link
Collaborator

hovind commented Feb 21, 2025

Nice! I also started working on the first small steps towards it. But if you're working on it: do you plan to make a PR, @hovind ?

I don't have any immediate plans to make a PR. I've had most of this code laying around since May 2024 to give you an idea of the lack of progress, it's just something I've dabbled in every now and then in my spare time to help myself learn a bit of bzlmod. Just thought I'd share in case it were useful to anyone. :)

@hzeller
Copy link
Collaborator Author

hzeller commented Feb 21, 2025

ok. I'll start chipping away on it then with little PRs here and there.

@hovind
Copy link
Collaborator

hovind commented Feb 21, 2025

ok. I'll start chipping away on it then with little PRs here and there.

That sounds like a good approach, I'm looking forward to following your progress!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants