From b793745a00019eecfc6a9c7724683407f8ec8ca2 Mon Sep 17 00:00:00 2001 From: Tim 'mithro' Ansell Date: Sun, 19 Nov 2023 16:28:12 -0800 Subject: [PATCH 1/2] Tabs in `bzl` files fix. Convert tabs to spaces. Signed-off-by: Tim 'mithro' Ansell --- place_and_route/open_road.bzl | 2 +- static_timing/build_defs.bzl | 2 +- synthesis/build_defs.bzl | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/place_and_route/open_road.bzl b/place_and_route/open_road.bzl index 8a3b9e59..8ed01ca3 100644 --- a/place_and_route/open_road.bzl +++ b/place_and_route/open_road.bzl @@ -259,7 +259,7 @@ def openroad_command(ctx, commands, input_db = None, step_name = None, inputs = }, execution_requirements = execution_requirements, mnemonic = "OpenROAD", - toolchain = None, + toolchain = None, ) return struct(db = output_db, log_file = log_file) diff --git a/static_timing/build_defs.bzl b/static_timing/build_defs.bzl index a03fd273..a1b8cca7 100644 --- a/static_timing/build_defs.bzl +++ b/static_timing/build_defs.bzl @@ -54,7 +54,7 @@ def _run_opensta_impl(ctx): input_manifests = input_manifests, env = env, mnemonic = "RunningSTA", - toolchain = None, + toolchain = None, ) return [ diff --git a/synthesis/build_defs.bzl b/synthesis/build_defs.bzl index c110efbe..d8934fcc 100644 --- a/synthesis/build_defs.bzl +++ b/synthesis/build_defs.bzl @@ -150,7 +150,7 @@ def _synthesize_design_impl(ctx): input_manifests = input_manifests, env = env, mnemonic = "SynthesizingRTL", - toolchain = None, + toolchain = None, ) return [ From c9a40bfbbed2d4732083c496895287ab5484aceb Mon Sep 17 00:00:00 2001 From: Tim 'mithro' Ansell Date: Sun, 19 Nov 2023 14:29:37 -0800 Subject: [PATCH 2/2] Add `toolchain = None` to `flows/flows.bzl`. Fixes; ``` ERROR: flows/tests/BUILD:63:9: in run_flow rule //flows/tests:synth_sky130_adder:Traceback (most recent call last): File "flows/flows.bzl", line 266, column 44, in _run_flow_impl inputs_dict = _run_step_with_inputs(ctx, step, inputs_dict, outputs_step_dict) File "flows/flows.bzl", line 207, column 20, in _run_step_with_inputs ctx.actions.run( Error in run: Couldn't identify if tools are from implicit dependencies or a toolchain. Please set the toolchain parameter. If you're not using a toolchain, set it to 'None'. ``` Signed-off-by: Tim 'mithro' Ansell --- flows/flows.bzl | 1 + 1 file changed, 1 insertion(+) diff --git a/flows/flows.bzl b/flows/flows.bzl index 50f5b3fd..72d4f706 100644 --- a/flows/flows.bzl +++ b/flows/flows.bzl @@ -213,6 +213,7 @@ def _run_step_with_inputs(ctx, step, inputs_dict, outputs_step_dict): mnemonic = step[FlowStepInfo].executable_type, env = dicts.add(constants_env, inputs_env, outputs_env), input_manifests = input_manifests, + toolchain = None, ) return dicts.add(inputs_dict, outputs_dict)