New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text protocol buffer: place `estimation_method` at right level. #361

Merged

mikesinouye merged 1 commit into hdl:main from hzeller:feature-20241016-fix-textproto

Oct 16, 2024

Collaborator

hzeller commented Oct 16, 2024

Make textproto parseable.

According to the schema, the estimation_method is part of the 'Power' message, not a sub-element of the PowerBreakdown message.

Also: estimation_method is a string, so it needs to be quoted.


          Fix text protocol buffer: place estimation_method at right level.

6a17244

Make textproto parseable.

According to [the schema](https://github.com/hdl/bazel_rules_hdl/blob/main/synthesis/power_performance_area.proto#L200),
the estimation_method is part of the 'Power' message, not a sub-element of the
PowerBreakdown message.

Also: estimation_method is a string, so it needs to be quoted.

hzeller requested a review from mikesinouye

October 16, 2024 19:46

mikesinouye approved these changes

View reviewed changes

mikesinouye merged commit 8657ee9 into hdl:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet