Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Side HTL (pagerenderer/server) #618

Open
cmrockwell opened this issue Oct 21, 2020 · 1 comment
Open

Server Side HTL (pagerenderer/server) #618

cmrockwell opened this issue Oct 21, 2020 · 1 comment
Labels
1.0.0 Release Any fixes or enhancements required for the 1.0.0 release htl Sling HTL Rendering sling12

Comments

@cmrockwell
Copy link
Collaborator

cmrockwell commented Oct 21, 2020 •
edited
Loading

HTL Use Case Overview

How to incorporate HTL Sightly? It may be common problem, because devs might need to use HTL instead of Vue rendering on the clientside. An HTL theme could grow and be supported as it would serve as an example removing a barrier migrating htl apps.

Current Condition

Peregrine CMS has server side rendering support from peregrine-cms/pagerenderer/server

Problems and purpose of this ticket

The purpose of this ticket is to Fix the deployment issues deploying this module peregrine-cms/pagerenderer/server to develop-sling12.
@cmrockwell cmrockwell added sling12 htl Sling HTL Rendering labels Oct 21, 2020
@cmrockwell cmrockwell mentioned this issue Oct 22, 2020
Closed
@cmrockwell cmrockwell assigned cmrockwell and unassigned cmrockwell Oct 22, 2020
@cmrockwell
Copy link
Collaborator Author

I can add components to the template either through the content packages or Composum, and see the content render in the template when viewed directly. But there seems to be fundamental piece missing that should merge the template content to the page content. When I view pages based on the template, I do not see the added template content.

Should this class be used by the page/Helper.java?

https://github.com/headwirecom/peregrine-cms/blob/develop/platform/base/core/src/main/java/com/peregrine/nodetypes/merge/PageMerge.java

cmrockwell added a commit that referenced this issue Oct 27, 2020
@cmrockwell
#618 Moved Helper.java to core, and updated data-sly-use in page.html…
51469da 
…. Refactored Helper.java to allow siteCSS to exist under per:Site/jcr:content
cmrockwell added a commit that referenced this issue Oct 28, 2020
@cmrockwell
#618 Updated PageMerge.java adding a method (getMergedResources) retu…
0a057d2 
…rning a list of resources coming either from the template or the page content.
cmrockwell added a commit that referenced this issue Oct 28, 2020
@cmrockwell
#618 Updated page.html to use PageMerge.java for getting and iteratin…
750a23b 
…g merged resources as htl
cmrockwell added a commit that referenced this issue Oct 28, 2020
@cmrockwell
#618 updated predifned page and template content
1befe34
cmrockwell added a commit that referenced this issue Oct 30, 2020
@cmrockwell
#618 Added getters for all HTL Java Use binding for BaseHelper, updat…
49e5a7d 
…ed PageHelper to use getters instead of direct access
cmrockwell added a commit that referenced this issue Oct 30, 2020
@cmrockwell
#618 Added convenience method to PerBase for getting per:Site/jcr:con…
5d4b073 
…tent ValueMap
cmrockwell added a commit that referenced this issue Nov 6, 2020
@cmrockwell
#618 refactored PageMerge to make it possible to test: If the slingSc…
5540d0d 
…riptHelper is null, then it will try to get the modelFactory from the bindings, which is added by the Adaption Jtest adds it. Use classes have bindings such as resource. Getting the resource from the request was problematic for testing, it is easier to test if PageMaerg.java uses the resource reference from the bindings, and not the reference attached to the request
cmrockwell added a commit that referenced this issue Nov 6, 2020
@cmrockwell
#618 Added test content for SSR scenario 2: inheriting template conte…
c15d91c 
…nt from a parent template
cmrockwell added a commit that referenced this issue Nov 6, 2020
@cmrockwell
#618 Updated getChildren method to resolve children resources from pa…
237b967 
…rent templates
@cmrockwell cmrockwell mentioned this issue Nov 18, 2020
Merged
This was referenced Dec 10, 2020
Closed
Closed
@ehdatheadwire ehdatheadwire added 1.0.0 Release Any fixes or enhancements required for the 1.0.0 release scrubbed Ticket has been reviewed and assessed labels Mar 12, 2021
@reusr1 reusr1 mentioned this issue Mar 13, 2021
Open
@ehdatheadwire ehdatheadwire removed the scrubbed Ticket has been reviewed and assessed label Mar 16, 2021
cmrockwell added a commit that referenced this issue Apr 26, 2021
@cmrockwell
Merge pull request #624 from /issues/618-htl-server
f5bce05 
Issues/618 htl server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0.0 Release Any fixes or enhancements required for the 1.0.0 release htl Sling HTL Rendering sling12
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmrockwell @ehdatheadwire