Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MouseCursor::Grab and ::Grabbing look like ::Move on Win10 #42

Open
PvdBerg1998 opened this issue Jun 9, 2019 · 5 comments
Open

MouseCursor::Grab and ::Grabbing look like ::Move on Win10 #42

PvdBerg1998 opened this issue Jun 9, 2019 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@PvdBerg1998
Copy link
Contributor

This is probably a winit bug 😰

@hecrj hecrj added the bug Something isn't working label Jun 9, 2019
@PvdBerg1998
Copy link
Contributor Author

Bump

@hecrj
Copy link
Owner

hecrj commented Jul 11, 2019

I am currently focusing on #63. I do not have a Windows 10 environment right now, but I will try to take a look at this soon.

That said, feel free to investigate yourself! winit is looking for contributors, they will really appreciate your efforts.

@hecrj hecrj added this to the 0.4.0 milestone Jul 11, 2019
@hecrj hecrj added the help wanted Extra attention is needed label Jul 11, 2019
@hecrj
Copy link
Owner

hecrj commented Jul 11, 2019

I just took a quick look. The issue seems to be here: https://github.com/rust-windowing/winit/blob/026b331ba54e1a49909242d72c5d78ed0d24b255/src/platform_impl/windows/util.rs#L167

The Windows API doesn't seem to expose a grab/grabbing cursor by default: https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-loadcursorw It seems that it has to be loaded as a custom cursor from a file or something. It doesn't look like a simple fix, but we should probably investigate a bit further.

I have created an issue in winit: rust-windowing/winit#1043

@PvdBerg1998
Copy link
Contributor Author

I don't have time currently, I just bumped it because you wanted me to create this issue so you wouldn't forget to report it to winit.

@hecrj
Copy link
Owner

hecrj commented Jul 12, 2019

For now, I keep track of all the issues (there aren't too many of them yet 😅).

I didn't report it because I figured it wouldn't probably be an easy fix, it feels low-priority, and I know winit is missing contributors. I should have commented that here.

I wanted to try to fix it myself after working on Wasm support. One thing at a time. But thinking about it, it won't hurt reporting it I guess.

In any case, I appreciate your concern. Thank you!

@hecrj hecrj modified the milestones: 0.4.0, 0.5.0 May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants