This repository has been archived by the owner on Jun 1, 2020. It is now read-only.
Fix creds extraction when 1 use only one node #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,6 +114,11 @@ if [ -f $INSECURE_KEY_FILE ]; then | |||
| echo " Riak CS credentials:" | |||
| echo | |||
|
|
|||
| # If starting only one node we need to wait a litle bit for keys | |||
| if [ ${DOCKER_RIAK_CS_CLUSTER_SIZE} -eq 1 ] ; then | |||
There was a problem hiding this comment.
Sorry for the late review, but I believe this line should be:
if [[ ${DOCKER_RIAK_CS_CLUSTER_SIZE} -eq 1 ]] ; thenThere was a problem hiding this comment.
There is no problem since I use '-eq', but add double quotes should be more secure.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When I start a cluster with only one node (DOCKER_RIAK_CS_CLUSTER_SIZE=1) the credentials printed are not correct. This is just a fix to wait some time in that case. It also could be done using pooling until admin_key change from admin-key, what do you think?