To merge

.flake8

@@ -0,0 +1,12 @@
+[flake8]
+max-complexity = 10
+max-line-length = 127
+
+exclude =
+    .git,
+    build,
+    data,
+    debian,
+    dist,
+    *.egg-info,
+    site-packages

.flake8.soft

@@ -0,0 +1,5 @@
+[flake8]
+per-file-ignores =
+    # Because of their nature, tests have a lot of long strings
+    # Perhaps the situation can be improved in the future
+    tests/*: E501

.github/pull_request_template.md

@@ -0,0 +1,8 @@
+<!-- Note: Only PRs where the automated tests pass will be reviewed, so make sure they pass -->
+## Description
+
+<!-- Describe what was changed -->
+
+## Checklist
+
+ - [ ] _CHANGELOG.md_ was updated (**format**: - Change made (thanks to github_username))

.github/workflows/changelogtest.yml

@@ -0,0 +1,15 @@
+name: Changelog test
+
+on: [pull_request]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: Check changelog format
+      run: |
+        ./scripts/check-changelog.sh
+

.github/workflows/pythontests.yml

@@ -10,7 +10,7 @@ jobs:
     steps:
     - uses: actions/checkout@v1
     - name: Set up Python 3.8
-      uses: actions/setup-python@v1
+      uses: actions/setup-python@v4
       with:
         python-version: 3.8
     - name: Install dependencies
@@ -19,7 +19,11 @@ jobs:
         pip install -r requirements-testing.txt
     - name: Lint with flake8
       run: |
-        flake8 . --count --max-complexity=10 --max-line-length=127 --show-source --statistics --exit-zero
+        flake8 . --append-config=.flake8.soft --count --show-source --statistics
+    - name: Lint with flake8 (strict, but non-fatal)
+      run: |
+        flake8 . --count --show-source --statistics --exit-zero
     - name: Run unit tests
       run: |
-        python -m unittest tests/*.py
+        python3 -m coverage run --source minigalaxy -m unittest discover -v tests && python3 -m coverage report -m
+

.github/workflows/release.yml

@@ -0,0 +1,44 @@
+name: Release
+
+on: workflow_dispatch
+
+jobs:
+  release:
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Install dependencies
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y debhelper-compat dh-sequence-python3 python3-all python3-setuptools help2man devscripts gettext lsb-release xmlstarlet git
+    - uses: actions/checkout@v3
+      with:
+        ref: master
+    - name: Prepare release files
+      id: tag
+      run: |
+        ./scripts/create-release.sh
+      env:
+        DEBFULLNAME: ${{ secrets.DEBFULLNAME }}
+        DEBEMAIL: ${{ secrets.DEBEMAIL }}
+    - name: Build deb package
+      run: |
+        dpkg-buildpackage -us -uc
+    - name: Commit changes
+      run: |
+        git config --global user.name 'Wouter Wijsman'
+        git config --global user.email '[email protected]'
+        git add pyproject.toml data/io.github.sharkwouter.Minigalaxy.metainfo.xml debian/changelog minigalaxy/version.py
+        git commit -m "Add new release"
+        git push
+    - name: Release
+      uses: softprops/action-gh-release@v1
+      with:
+        tag_name: ${{ steps.tag.outputs.VERSION }}
+        name: Minigalaxy version ${{ steps.tag.outputs.VERSION }}
+        body_path: release.md
+        prerelease: true
+        files: |
+          ../minigalaxy_*.deb
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.gitignore

@@ -9,8 +9,11 @@ dist/
 .eggs/
 data/mo/
 data/po/minigalaxy.pot
+data/po/*.mo
 .project
 .pydevproject
+release.md
+.coverage
 
 # Files generated when building the deb package
 .pybuild/
@@ -24,3 +27,4 @@ debian/minigalaxy.substvars
 debian/minigalaxy.debhelper.log
 debian/minigalaxy.postinst.debhelper
 debian/minigalaxy.prerm.debhelper
+.vscode/settings.json

CHANGELOG.md

@@ -1,3 +1,137 @@
+**1.3.2**
+- Completely reworked windows wine installation. This should solve a lot of problems with failing game installs (thanks to GB609)
+- Variables and arguments in game settings can now contain blanks when quoted shell-style (thanks to GB609)
+- Minigalaxy will now create working Desktop Shortcuts for wine games (thanks to GB609)
+
+**1.3.1**
+- Fix Windows games with multiple parts not installing with wine
+- Minor AppData fixes (thanks to tim77)
+- Added Portuguese translation (thanks to GLSWV)
+
+**1.3.0**
+- Fix Remove forward slash from desktop filename for Shenzhen I/O (thanks to slowsage)
+- Fix race when preparing download location (thanks to viacheslavka)
+- Fix multithreaded downloads of Windows games (thanks to viacheslavka)
+- Fix DLC installation for Windows games (thanks to viacheslavka)
+- Allow users to specify the download directory (thanks to viacheslavka)
+
+**1.2.6**
+- Fix changing the install path causing an exception
+- Fix error detection & reporting on wineprefix creation failure (thanks to LeXofLeviafan)
+
+**1.2.5**
+- Fix filtering for installed games
+
+**1.2.4**
+- Fix packages missing a script
+
+**1.2.3**
+- Fix short freeze on startup (thanks to LeXofLeviafan)
+- Fix game information not showing in list view (thanks to TotalCaesar659)
+- Hide A Plague Tale Digital Goodies Pack (thanks to TotalCaesar659)
+- Remove round corners from top of the "play" button (thanks to lmeunier)
+- Move the Gametile menu button alongside the Play button (thanks to lmeunier)
+- Update Spanish translation (thanks to manurtinez)
+- Capitalize first letter of the "play/download/..." button (thanks to lmeunier)
+- Update Traditional Chinese translation (thanks to s8321414)
+- Added additional tooltips to buttons, labels, menu items and radio buttons (thanks to orende)
+- Hide CDPR Goodie Pack Content
+- Add notifications on successful download and installation of games (thanks to orende)
+- Add category filtering dialog for game library (thanks to orende)
+- Parallelize api.can_connect function with threads, futures (thanks to orende)
+- Fix available disk space being checked in parent directory (thanks to Unrud)
+- Create new config if reading it fails
+
+**1.2.2**
+- Fix progress bar not showing up for downloads
+- Fix downloads not being cancellable
+- Fix incompatibility with python 3.6
+- Fix connection error texts (thanks to TotalCaesar659)
+- Show DLC titles in English (thanks to TotalCaesar659)
+- Fix version not being updated during a release
+- Update Norwegian Bokmål translation (thanks to kimmalmo)
+- Update Czech translation (thanks to jakbuz23)
+
+**1.2.1**
+- Fix downloads failing when content length is not returned by the server
+- Allow different types of downloads to happen at the same time (thanks to jgerrish)
+- Fix metadata file having releases in wrong order
+
+**1.2.0**
+- Split game information and properties into different windows (thanks to TotalCaesar659)
+- Add list view (thanks to TotalCaesar659)
+- Allow DLC to be queued up for downloading (thanks to flagrama)
+- Fix changing library to a directory with special characters in the name (thanks to makson96)
+- Fix signing in with Facebook (thanks to phlash)
+- Always use cached DLC icons and thumbnails (thanks to TotalCaesar659)
+- Cache information covers (thanks to TotalCaesar659)
+- Fix installers not being cleaned up like expected (thanks to Kzimir)
+- Fix error when opening game properties window when wine is not installed (thanks to lmeunier)
+- Fix freeze for games generating a lot of output (thanks to lmeunier)
+- Fix extracting rar based games with innoextract (thanks to Kzimir)
+- Allow setting wine executable per game (thanks to Kzimir)
+- Add GameMode support (thanks to TotalCaesar659)
+- Add MangoHud support (thanks to TotalCaesar659)
+- Add option to use Winetricks (thanks to TotalCaesar659)
+- Fix updates not always being detected directly after opening Minigalaxy (thanks to TotalCaesar659)
+- Fix desktop files generated not always being able to launch (thanks to otaconix)
+- Show percentage when hovering over download progress bar (thanks to TotalCaesar659)
+- Add option to disable update check per game (thanks to TotalCaesar659)
+- Add forum, GOG Database and PCGamingWiki URLs to game information (thanks to TotalCaesar659)
+- List genre as unknown in game information when none is found (thanks to mareksapota)
+- Fix changing installation path causing crashes in rare cases (thanks to makson96)
+- Fall back to English when locale cannot be determined (thanks to flagrama)
+- Add gettext to build dependencies (thanks to larslindq)
+- Improve error handling upon API errors
+- Fix several issues with launching Windows games from Minigalaxy
+- Fix some games getting stuck on in queue
+- Fix Windows game installation not caring about preferred language (thanks to Kzimir)
+
+- Add Greek translation (thanks to Pyrofanis)
+- Add Spanish (Spain) translation (thanks to mbarrio)
+- Add Romanian (Romania) translation (thanks to xSlendiX)
+
+- Update Norwegian Bokmål translation (thanks to kimmalmo)
+- Update Czech translation (thanks to jakbuz23)
+
+**1.1.0**
+- Improve integrity check after downloading (thanks to makson96)
+- Show an error showing Windows games cannot be enabled 
+- Add properties menu for games where game specific actions can be made like setting launch options and opening the store page (thanks to Odelpasso and makson96)
+- Add a disk space check before downloading (thanks to SvdB-nonp and makson96)
+- Use a different color for the play button for installed games
+- Put installed games at the top of the list
+- Store saved installers in ``~/GOG Games/installer`` by default again (thanks to makson96)
+- Remember if the user had the installed filter enabled (thanks to makson96)
+- Extract Windows games in the background if Innoextract is available (thanks to makson96)
+- Extract Windows games in the background (thanks to Odelpasso)
+- Fix installing DLC for Windows games (thanks to makson96)
+- Fix an error showing if the user has no games (thanks to makson96)
+- Add option to hide games (thanks to TotalCaesar659)
+- Ask user if they are sure when logging out (thanks to TotalCaesar659)
+- Add a dark theme (thanks to TotalCaesar659)
+- Run post install script after installation. This fixes Full Throttle Remastered (thanks to makson96)
+- Fix games being shown twice
+- Fix crash when GOG is down (thanks to lmeunier)
+- Make the language configurable (thanks to TotalCaesar659 and zweif)
+
+- Add the following translations:
+  - Czech (thanks to jakbuz23)
+  - Finnish (thanks to heidiwenger and jonnelafin)
+  - Italian (thanks to koraynilay)
+  - Swedish (thanks to Newbytee)
+  - Ukrainian (thanks to karaushu)
+
+- Update the following translations:
+  - Dutch
+  - German (thanks to zweif)
+  - Norwegian Nynorsk (thanks to LordPilum)
+  - Polish (thanks to ArturWroblewski)
+  - Russian (thanks to TotalCaesar659)
+  - Simplified Chinese (thanks to dummyx)
+  - Spanish (thanks to LocalPinkRobin and advy99)
+  - Turkish (thanks to fuzunspm)
+
 **1.0.2**
 - Fix updates sometimes not working
 - Fix some games always showing an update is available

LICENSE

@@ -1,12 +1,11 @@
+                    GNU GENERAL PUBLIC LICENSE
+                       Version 3, 29 June 2007
 
-		    GNU GENERAL PUBLIC LICENSE
-		       Version 3, 29 June 2007
-
- Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
+ Copyright (C) 2007 Free Software Foundation, Inc. <https://fsf.org/>
  Everyone is permitted to copy and distribute verbatim copies
  of this license document, but changing it is not allowed.
 
-			    Preamble
+                            Preamble
 
   The GNU General Public License is a free, copyleft license for
 software and other kinds of works.
@@ -69,15 +68,15 @@ patents cannot be used to render the program non-free.
   The precise terms and conditions for copying, distribution and
 modification follow.
 
-		       TERMS AND CONDITIONS
+                       TERMS AND CONDITIONS
 
   0. Definitions.
 
   "This License" refers to version 3 of the GNU General Public License.
 
   "Copyright" also means copyright-like laws that apply to other kinds of
 works, such as semiconductor masks.
- 
+
   "The Program" refers to any copyrightable work licensed under this
 License.  Each licensee is addressed as "you".  "Licensees" and
 "recipients" may be individuals or organizations.
@@ -510,7 +509,7 @@ actual knowledge that, but for the patent license, your conveying the
 covered work in a country, or your recipient's use of the covered work
 in a country, would infringe one or more identifiable patents in that
 country that you have reason to believe are valid.
-  
+
   If, pursuant to or in connection with a single transaction or
 arrangement, you convey, or propagate by procuring conveyance of, a
 covered work, and grant a patent license to some of the parties
@@ -619,9 +618,9 @@ an absolute waiver of all civil liability in connection with the
 Program, unless a warranty or assumption of liability accompanies a
 copy of the Program in return for a fee.
 
-		     END OF TERMS AND CONDITIONS
+                     END OF TERMS AND CONDITIONS
 
-	    How to Apply These Terms to Your New Programs
+            How to Apply These Terms to Your New Programs
 
   If you develop a new program, and you want it to be of the greatest
 possible use to the public, the best way to achieve this is to make it
@@ -646,7 +645,7 @@ the "copyright" line and a pointer to where the full notice is found.
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+    along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 Also add information on how to contact you by electronic and paper mail.
 
@@ -665,12 +664,11 @@ might be different; for a GUI interface, you would use an "about box".
   You should also get your employer (if you work as a programmer) or school,
 if any, to sign a "copyright disclaimer" for the program, if necessary.
 For more information on this, and how to apply and follow the GNU GPL, see
-<http://www.gnu.org/licenses/>.
+<https://www.gnu.org/licenses/>.
 
   The GNU General Public License does not permit incorporating your program
 into proprietary programs.  If your program is a subroutine library, you
 may consider it more useful to permit linking proprietary applications with
 the library.  If this is what you want to do, use the GNU Lesser General
 Public License instead of this License.  But first, please read
-<http://www.gnu.org/philosophy/why-not-lgpl.html>.
-
+<https://www.gnu.org/licenses/why-not-lgpl.html>.