From a3e91290a72ff48409216f54dd05468f992beb2d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9lder=20Pinto?= Date: Thu, 11 Apr 2024 16:34:48 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Michael Flanakin --- docs/optimization-engine/setup-options.md | 2 ++ docs/optimization-engine/suppressing-recommendations.md | 2 ++ src/optimization-engine/Deploy-AzureOptimizationEngine.ps1 | 2 ++ 3 files changed, 6 insertions(+) diff --git a/docs/optimization-engine/setup-options.md b/docs/optimization-engine/setup-options.md index 6299f9ce8..ff630dd73 100644 --- a/docs/optimization-engine/setup-options.md +++ b/docs/optimization-engine/setup-options.md @@ -21,6 +21,8 @@ Advanced scenarios for setting up or upgrading AOE. +--- + ## 🎛️ Using a local repository If you choose to deploy all the dependencies from your own local repository, you must publish the solution files into a publicly reachable URL. You must ensure the entire AOE project structure is available at the same base URL. Storage Account SAS Token-based URLs are not supported. diff --git a/docs/optimization-engine/suppressing-recommendations.md b/docs/optimization-engine/suppressing-recommendations.md index c7fa09be1..a80121534 100644 --- a/docs/optimization-engine/suppressing-recommendations.md +++ b/docs/optimization-engine/suppressing-recommendations.md @@ -19,6 +19,8 @@ Adjust the recommendations results to your environment characteristics. +--- + When working on the recommendations provided by AOE, you may find some cases where the recommendation does not apply for some reason. For example, AOE is suggesting high availability recommendations that do not apply to Dev/Test Virtual Machines, or recommending enabling Azure Backup for non-critical VMs. You can suppress recommendations in two ways: * If recommendations are originated from Azure Advisor, you can simply go to the Azure Portal and [dismiss/postpone the recommendation](https://docs.microsoft.com/en-us/azure/advisor/view-recommendations#dismissing-and-postponing-recommendations). diff --git a/src/optimization-engine/Deploy-AzureOptimizationEngine.ps1 b/src/optimization-engine/Deploy-AzureOptimizationEngine.ps1 index b5e255750..f3884a035 100644 --- a/src/optimization-engine/Deploy-AzureOptimizationEngine.ps1 +++ b/src/optimization-engine/Deploy-AzureOptimizationEngine.ps1 @@ -1,3 +1,4 @@ +# TODO: Add doc comments param ( [Parameter(Mandatory = $false)] [string] $TemplateUri, @@ -472,6 +473,7 @@ if ($null -eq $sql -and -not($sqlServerName -like "*.database.*") -and -not($Ign $SqlServerNameAvailabilityUriPath = "/subscriptions/$subscriptionId/providers/Microsoft.Sql/checkNameAvailability?api-version=2014-04-01" $body = "{`"name`": `"$sqlServerName`", `"type`": `"Microsoft.Sql/servers`"}" + # TODO: Switch to custom Invoke-Rest command to leverage telemetry tracking $sqlNameResult = (Invoke-AzRestMethod -Path $SqlServerNameAvailabilityUriPath -Method POST -Payload $body).Content | ConvertFrom-Json if (-not($sqlNameResult.available)) {