Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does pip install kamodo miss anything? #3

Open
sapols opened this issue Jun 20, 2024 · 6 comments
Open

Does pip install kamodo miss anything? #3

sapols opened this issue Jun 20, 2024 · 6 comments

Comments

@sapols
Copy link
Contributor

sapols commented Jun 20, 2024

We've tended to install Kamodo via git in the past. Yet this simply installs it via pip install kamodo. Ask the package maintainers if this is an issue or not.

@sapols
Copy link
Contributor Author

sapols commented Jun 26, 2024

If we do end up adding something missing, publish the new PyPI version via GitHub Actions (#7).

@sapols
Copy link
Contributor Author

sapols commented Jun 27, 2024

Emailed Darren about this.

@sapols
Copy link
Contributor Author

sapols commented Jul 18, 2024

Heard back from Darren, and yes it is missing stuff:

So unfortunately the development of Kamodo has changed direction a few times at the beginning. One consequence is that ‘pip install kamodo’ just installs the Kamodo-core and thus none of the CCMC model readers or advanced viaualization. On the other hand, ‘pip install kamodo-ccmc’ does install the full Kamodo package. However, that right now is more than a year out of date and is missing many upgrades and fixes. That’s why for now we are recommending to install from GitHub. It’s on my list to fix this summer and get PyPI updated with the latest version.

@sapols
Copy link
Contributor Author

sapols commented Aug 8, 2024

I believe pyproject.toml supports git dependencies with this syntax:

dependencies = [
  "sphinx@git+https://github.com/sphinx-doc/sphinx",
]

(source / alt source)

So might be as simple as replacing "kamodo", in the dependencies with "kamodo@git+https://github.com/nasa/Kamodo.git",

@sapols
Copy link
Contributor Author

sapols commented Aug 13, 2024

I had to use "kamodo-ccmc@git+https://github.com/nasa/Kamodo.git", instead because pip complained the package metadata was named kamodo-ccmc not just kamodo.

@sapols
Copy link
Contributor Author

sapols commented Aug 13, 2024

WHELP, never mind. I set up Kamodo to install from git, only for PyPI to error during the upload with a message stating that it's against their rules to have package dependencies that install from git: https://github.com/heliophysicsPy/pyhc-core/actions/runs/10375172727/job/28724242403

So we've hit a wall. Kamodo will simply have to fix its pip install so that installing from git won't be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant