Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2.0.0 breaks our environment #12

Open
sapols opened this issue Jun 17, 2024 · 2 comments
Open

Numpy 2.0.0 breaks our environment #12

sapols opened this issue Jun 17, 2024 · 2 comments

Comments

@sapols
Copy link
Contributor

sapols commented Jun 17, 2024

Broke in run 189: https://github.com/heliophysicsPy/pyhc-docker-environment/actions/runs/9543369553

Idk what the exact problem/fix is yet.

@sapols
Copy link
Contributor Author

sapols commented Jun 18, 2024

Seems all that happened was numpy 2.0.0 was getting pulled in as a pipeline dependency, which broke the first pandas import statement in pipeline.py. Adding numpy<2.0.0 to the top of pipeline-requirements.txt fixed it.

However, because apparently no packages currently have a numpy<2 upper bound, version 2.0.0 is getting installed into the environment, which breaks things when you go to use it. We'll have to manually add that upper bound, for now.

@sapols sapols changed the title Numpy 2.0.0 broke our environment Numpy 2.0.0 breaks our environment Jun 18, 2024
@sapols
Copy link
Contributor Author

sapols commented Jun 18, 2024

Temporarily specifying that our environment use numpy==1.26.4 (the latest version before 2) by adding specify_numpy_1_26_4(docker_requirements_path) to pipeline.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant