Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Material Icons to work Offline #92

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Updated Material Icons to work Offline #92

merged 5 commits into from
Aug 2, 2024

Conversation

hello-vinitha
Copy link
Collaborator

@hello-vinitha hello-vinitha commented Aug 2, 2024 •
edited by hello-amal
Loading

Description

This PR updates the material icons dependency to work offline by installing the dependency locally instead of linking the CDN.

Testing procedure

  • Run npm install --legacy-peer-deps
  • Launch the interface
  • Verify all the icons are visible for the following components (online and offline):
    • Layout with all 3 camera views
    • Sidebar
    • Movement Recorder
    • Text-to-Speech
    • Customization Mode (i.e. click on a component in the sidebar)

Before opening a pull request

From the top-level of this repository, run:

  • pre-commit run --all-files

To merge

  • Squash & Merge

@hello-vinitha
Copy link
Collaborator Author

Tests pass with 3030 online.

@hello-amal
Copy link
Collaborator

Tests pass with 3053 offline

@hello-amal hello-amal merged commit 232babd into master Aug 2, 2024
1 check passed
@hello-amal hello-amal deleted the vinitha/offline_icons branch August 2, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hello-vinitha hello-vinitha

@hello-amal hello-amal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hello-vinitha @hello-amal