The ActioByteSize does not allow an empty string. That should lead …

…to `argument flag: value cannot be empty.` covered in test: 'Unit only is invalid.'.'
helly25 · Sep 6, 2024 · b29fc79 · b29fc79
1 parent 6ed8527
commit b29fc79
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 8 deletions.
diff --git a/mbo/app/flags.py b/mbo/app/flags.py
@@ -489,6 +489,8 @@ def ParseByteSize(
             f"value does not match pattern (not a valid byte size), got '{original}'."
         )
     number = match.group(1)
+    if number == "":
+        raise ValueError("value cannot be empty.")
     if number == ".":
         raise ValueError("value cannot be '.'.")
     result = float(number) if number.find(".") > -1 else int(number)

diff --git a/mbo/app/flags_test.py b/mbo/app/flags_test.py
@@ -678,22 +678,22 @@ def test_ActionDateTimeOrTimeDelta(self, test: FlagTestData):
     @parameterized.expand(
         [
             FlagTestData(
-                test="Parse empty.",
-                expected="argument flag: value must not be empty.",
-                expected_error=argparse.ArgumentError,
+                test="Parse default None.",
+                expected=None,
                 action=ActionArgs(
                     action=mbo.app.flags.ActionByteSize,
+                    nargs="?",
                 ),
-                input=[""],
+                input=[],
             ),
             FlagTestData(
-                test="Parse default None.",
-                expected=None,
+                test="Parse empty.",
+                expected="argument flag: value must not be empty.",
+                expected_error=argparse.ArgumentError,
                 action=ActionArgs(
                     action=mbo.app.flags.ActionByteSize,
-                    nargs="?",
                 ),
-                input=[],
+                input=[""],
             ),
             FlagTestData(
                 test="Parse default value.",
@@ -723,6 +723,15 @@ def test_ActionDateTimeOrTimeDelta(self, test: FlagTestData):
                 ),
                 input=["0"],
             ),
+            FlagTestData(
+                test="Unit only is invalid.",
+                expected="argument flag: value cannot be empty.",
+                expected_error=argparse.ArgumentError,
+                action=ActionArgs(
+                    action=mbo.app.flags.ActionByteSize,
+                ),
+                input=["B"],
+            ),
             FlagTestData(
                 test="Parse zero bytes.",
                 expected=[0, 0, 0, 0, 0],