Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support device awareness of result_type, promote_types #1820

Open
ClaudiaComito opened this issue Mar 10, 2025 · 0 comments
Open

Support device awareness of result_type, promote_types #1820

ClaudiaComito opened this issue Mar 10, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers HW:MPS types

Comments

@ClaudiaComito
Copy link
Contributor

ClaudiaComito commented Mar 10, 2025 •
edited
Loading

Related
#1129 #1053

Feature functionality
Apple MPS don't support double precision floats or complex numbers, so we have had to introduce many dtype checks in the codebase (see #1129, example #1129 (comment) ). Most of these checks could be bypassed if type.result_type() and type.promote_types() were aware of what device they are setting the dtype for (for example with a kwarg device=None with options cpu, gpu, mps, potentially xpu later, see #1757 )

Additional context
PR meeting March 10 2025
@ClaudiaComito ClaudiaComito added enhancement New feature or request types HW:MPS good first issue Good for newcomers labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers HW:MPS types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ClaudiaComito