Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encodeURI helper is confusing #329

Open
macgyver opened this issue Sep 24, 2018 · 0 comments
Open

encodeURI helper is confusing #329

macgyver opened this issue Sep 24, 2018 · 0 comments

Comments

@macgyver
Copy link

macgyver commented Sep 24, 2018 •
edited
Loading

Maybe the API has existed for too long to change this now, but I found it confusing that the encodeURI helper calls encodeURIComponent, the naming of the helper maps very neatly to the javascript functions that are so familiar to us, but the functionality differs.

Would it not more accurately reflect its function if the helper were renamed to encodeURIComponent?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@macgyver