Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BATLData type unstable #65

Closed
3 tasks done
henry2004y opened this issue Nov 5, 2024 · 1 comment
Closed
3 tasks done

BATLData type unstable #65

henry2004y opened this issue Nov 5, 2024 · 1 comment

Comments

@henry2004y
Copy link
Owner

henry2004y commented Nov 5, 2024 •
edited
Loading

https://github.com/henry2004y/Batsrus.jl/blob/master/src%2FBatsrus.jl#L50

The current definition of the main data struct requires more type optimizations.

  • Move type definitions into a separate source file
  • Rename primitive structs; Data is too vague.
  • Add an abstract type AbstractBATS, parameterized with dimension.

References: https://discourse.julialang.org/t/parametrize-a-struct-with-numbers-not-types/108725

https://discourse.julialang.org/t/parametric-type-with-numbers/74544

https://docs.julialang.org/en/v1/manual/performance-tips/#Annotate-values-taken-from-untyped-locations

https://docs.julialang.org/en/v1/manual/performance-tips/#Avoid-fields-with-abstract-type
@henry2004y
Copy link
Owner Author

Closed via #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henry2004y