New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type instability in `fill_vector_from_scalars` #75

Open

henry2004y opened this issue Jan 27, 2025 · 0 comments

Owner

henry2004y commented Jan 27, 2025 •

edited

Loading

While get_vectors is type-stable

@code_warntype Batsrus.get_vectors(bd, :B)

fill_vector_from_scalars is not:

@code_warntype Batsrus.fill_vector_from_scalars(bd, :B)

│   %22 = Rpost::Any
│   %23 = Base.product(%21, %22)::Base.Iterators.ProductIterator{T} where T<:Tuple{UnitRange{Int64}, Any}
│   %24 = Base.Generator(%19, %23)::Base.Generator{...}
│   %25 = Base.collect(%24)::Any
│         (v = %25)
└──       return %25

It seems that the instability issue is not fully resolved.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment