From cb9a53256f87a6d42bd57bee4cf615abb1b394bf Mon Sep 17 00:00:00 2001 From: Henrique Vicente Date: Thu, 18 Dec 2014 11:02:53 -0800 Subject: [PATCH] Removing git_command setting. This is more appropriately solved by the user's shell (separation of concerns), also removes the dependency on the config module on the git module. --- .gh.json | 2 -- lib/git.js | 5 ++--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.gh.json b/.gh.json index 43586a94..7e76f77e 100644 --- a/.gh.json +++ b/.gh.json @@ -13,8 +13,6 @@ "default_pr_reviewer": "", - "git_command": "git", - "github_token": "", "github_user": "", diff --git a/lib/git.js b/lib/git.js index ec91877b..3b33dad6 100644 --- a/lib/git.js +++ b/lib/git.js @@ -11,8 +11,7 @@ var base = require('./base'), logger = require('./logger'), - spawn = require('child_process').spawn, - config = base.getConfig(); + spawn = require('child_process').spawn; exports.checkout = function(branch, opt_newBranch, opt_callback) { var args; @@ -71,7 +70,7 @@ exports.exec = function(cmd, args, opt_callback, opt_log) { args.unshift(cmd); - git = spawn(config.git_command, exports.deleteArrayEmptyValues_(args)); + git = spawn('git', exports.deleteArrayEmptyValues_(args)); git.stdout.on('data', function(data) { buf += data;