Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: entity computed property #69

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

VictorTBX
Copy link
Contributor

@VictorTBX VictorTBX commented Dec 28, 2022

#68

This is still a draft, I'd like of understand if I'm on the right path before continuing.

Proposed Changes

  1. Add feature for defining function properties, updating them when properties are set

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request -> Not yet
  • Remember to check if code coverage decrease, if so, please implement the necessary tests -> Some unit testes need to be rewriten due to the use of strictly deep-equal. I'll do this when I'm sure of the next steps.

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@dalssoft
Copy link
Member

great PR!

from #68 (comment)

I started developing this feature, but I'm stucked with two problems

with no tests I think it's hard to affirm it's only two problems... In order to improve this PR, even for a POC, tests are mandatory to understand the proposal and the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants