Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import ES Modules not working for react #10

Open
maikvortx opened this issue Oct 25, 2021 · 3 comments
Open

Import ES Modules not working for react #10

maikvortx opened this issue Oct 25, 2021 · 3 comments
Labels
bug Something isn't working hacktoberfest ready-to-work Item is ready to work on it severity-major Item is very important

Comments

@maikvortx
Copy link

Hello everyone!

I'm using react 16 with herbs and when I go to import the herbs module I get the herbs.csj file.

To Reproduce

Steps to reproduce the behavior:

  1. Using react 16
  2. Import ES Module from import herbs from '@herbsjs/herbs'
  3. Create a new entity

Expected behavior

Import ES Module with herbs functions like entity, field...

Screenshots

image
@maikvortx maikvortx added the bug Something isn't working label Oct 25, 2021
@jhomarolo jhomarolo added ready-to-work Item is ready to work on it severity-major Item is very important labels Dec 24, 2021
@italojs
Copy link
Member

italojs commented May 4, 2022

@maikvortx do you have some idea how to solve it?

@italojs
Copy link
Member

italojs commented Aug 2, 2022

@maikvortx this issue still alive?

@maikvortx
Copy link
Author

Hi @italojs! This "bug" is still alive! HAHHAA

I think that we need to use ESM in Herb's packages to work well with React Projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working hacktoberfest ready-to-work Item is ready to work on it severity-major Item is very important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jhomarolo @italojs @maikvortx