Create Serverless exemples and template configuration #123
Conversation
|
Great PR!!! Suggestion: there is a clear pattern for handlers. A quick refactoring would reduce the number of files drastically. Also, all the strings / messages must be in english. |
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
=======================================
Coverage ? 98.67%
=======================================
Files ? 15
Lines ? 226
Branches ? 0
=======================================
Hits ? 223
Misses ? 3
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Great refactoring! Now that you have much simple handler files it is clear they are not needed, given you could use herbs metadata to create this handlers on the fly, without need to have all these files, pretty much like herbs2rest or herbs2gql. |
|
Awesome PR @m7vicente! |
|
Remember to add it inside the out CLI :) |
|
It will be a big thing for the HerbsJS mature @m7vicente |
src/infra/handlers/defaultHandler.js
Outdated
| body: JSON.stringify(ucResult.ok), | ||
| } | ||
|
|
||
| if (ucResult.err === 'Not Authorized') |
There was a problem hiding this comment.
agree. check defaultController on herbs2rest https://github.com/herbsjs/herbs2rest/blob/main/src/defaultController.js
|
linter inst this PR proposal, please, make a change only is necessary for scope of this PR |
…e/todolist-on-herbs-serverless into poc-serverless-template
…e/todolist-on-herbs-serverless into poc-serverless-template
|
@m7vicente Is something missing or is it just a final review? |
All requested changes has been completed |
Added serverless and serverless offline suport for templete
Create handler for each usecase and especifications on yml.