Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crd customization #4

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ashithwilson
Copy link

@ashithwilson ashithwilson commented Oct 10, 2024

make install fails probably due to kustomization file missing. This PR adds it.

Before

❯ make install
Downloading sigs.k8s.io/controller-tools/cmd/[email protected]
/Users/ashith/git/ashithwilson/istio-fortsa/bin/controller-gen-v0.14.0 rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
Downloading sigs.k8s.io/kustomize/kustomize/[email protected]
/Users/ashith/git/ashithwilson/istio-fortsa/bin/kustomize-v5.3.0 build config/crd | kubectl apply -f -
Error: unable to find one of 'kustomization.yaml', 'kustomization.yml' or 'Kustomization' in directory '/Users/ashith/git/ashithwilson/istio-fortsa/config/crd'
error: no objects passed to apply
make: *** [install] Error 1

After

❯ make install
/Users/ashith/git/ashithwilson/istio-fortsa/bin/controller-gen-v0.14.0 rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/Users/ashith/git/ashithwilson/istio-fortsa/bin/kustomize-v5.3.0 build config/crd | kubectl apply -f -
clusterrole.rbac.authorization.k8s.io/manager-role created

@hercynium
Copy link
Owner

Can you please rebase your branch from main?

@hercynium hercynium merged commit 22948c0 into hercynium:main Oct 14, 2024
1 check passed
@ashithwilson ashithwilson deleted the ashith/fix-crd-kustomization branch October 14, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants