Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alloc: avoid padding the size of allocations #1059

Closed
mkroening opened this issue Feb 13, 2024 · 1 comment · Fixed by #1045
Closed

alloc: avoid padding the size of allocations #1059

mkroening opened this issue Feb 13, 2024 · 1 comment · Fixed by #1045
Assignees

Comments

@mkroening
Copy link
Member

From @SFBdragon in #1045 (comment):

Avoid padding the size of allocations. Increasing the alignment of an allocation is sufficient to avoid false sharing. Talc needs a little bit of metadata next to each allocation, and this would create N-8 sized holes in between every allocation due to the demands placed on it. By removing the size requirement, false sharing avoidance is unhindered, but this allows Talc to minimize the overhead of high-alignments. (Talc is designed to automatically place the metadata in a way that minimized false sharing, but this only helps if Talc can sneak it in within the same cache line, which is impossible if Talc thinks you want the whole cache line for user data.)

@mkroening mkroening self-assigned this Feb 13, 2024
@mkroening
Copy link
Member Author

This is currently blocked on some issue with AArch64 memory management, resulting in corruption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant