Use memory_address::{VirtAddr, PhysAddr} in the kernel
#1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jounathaen
force-pushed
the
memory_addresses
branch
from
97fd974
to
40d7893
Compare
|
Would probably be an interesting case for continuous benchmarking... |
jounathaen
force-pushed
the
memory_addresses
branch
from
77de4ab
to
30e23f3
Compare
jounathaen
force-pushed
the
memory_addresses
branch
10 times, most recently
from
6157301
to
dbb94e8
Compare
mkroening
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Memory addresses should ideally be formatted as {:p} (std::fmt::Pointer).
cagatay-y
reviewed
Nov 14, 2024
jounathaen
force-pushed
the
memory_addresses
branch
6 times, most recently
from
e5ad74b
to
32132c7
Compare
mkroening
force-pushed
the
memory_addresses
branch
2 times, most recently
from
e17c3de
to
a0c9c3a
Compare
Co-authored-by: Jonathan Klimt <[email protected]> Signed-off-by: Martin Kröning <[email protected]>
…rnel Additional (implied) changes - aarch64: made physical_address_and_flags an u64 - x86_apic: changed SMP offsets from usize to u64 - changed VGA_BUFFER_ADDRESS to PhysAddr - Updated aarch64 dependency to v0.0.13
mkroening
force-pushed
the
memory_addresses
branch
from
9fb8e83
to
74234fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on hermit-os/rust-aarch64#9