-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: improve output information #759
Conversation
Before:
After:
|
Can you cherry-pick 57f01a7 into this PR? |
b8295b4
to
eb85fbd
Compare
Recreated the commit with your author information, hope nothing broke in the process of doing so. |
- Print to stdout as soon as the kernel successfully boots - Print to stdout in run_simple_vm to make it clear that the kernel has been compiled - Clarify the test-kernel being built, as the "name mismatch" between fs-test.rs and create_file.rs can be a bit confusing - Add newline between build_hermit_bin + run_simple_vm output and output coming from the kernel - Minor linguistic improvements These changes may seem redundant to the trained eye (for example, it is safe to assume that the output starting with "frequency: ..." is from the kernel, thus everything that follows is from the kernel), but can be very helpful to beginners. Based on local changes that I created for personal use, so as to better understand the debugging process.
eb85fbd
to
355a3f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 67.79% 67.92% +0.13%
==========================================
Files 19 19
Lines 2453 2463 +10
==========================================
+ Hits 1663 1673 +10
Misses 790 790 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
P.S. wrote |
@jounathaen seems like this should not conflict with my WIP changes in #783, should be a rebase at most. Is that good to go? |
It is! Thanks for your contribution ❤️ |
These changes may seem redundant to the trained eye (for example, it is safe to assume that the output starting with "frequency: ..." is from the kernel, thus everything that follows is from the kernel), but can be very helpful to beginners.
Based on local changes that I created for personal use, so as to better understand the debugging process.