Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM package #135

Open
feraxhp opened this issue Aug 28, 2024 · 5 comments
Open

RPM package #135

feraxhp opened this issue Aug 28, 2024 · 5 comments

Comments

@feraxhp
Copy link

feraxhp commented Aug 28, 2024

i was able to compile a RPM package, to see if we can add it to the current github actions. If is posible to contribute

@herrhotzenplotz
Copy link
Owner

This sounds nice! I am happy to accept patches for creating RPM packages.

I personally don't use the GitHub Actions so adding a plain script that spits out the package, or perhaps adding a Makefile that does it, would be of greater value.
These can then be called from whatever CI service we use (currently GitLab Pipelines and Sourcehut Builds).

Then again, maybe we should put an effort into bringing gcli to Fedora (or whatever the common place for RPM packages is)?

I am open for discussions here.

@gbowne1
Copy link

gbowne1 commented Aug 29, 2024

I personally would do the Makefile option but. That's just me.

@feraxhp
Copy link
Author

feraxhp commented Aug 31, 2024

I have 0 skills written MAKE files. so i create a bash script to build it, but currently i am running it on a docker container.

You tell me how to give you the code. i am new with this kind of contributes.

😅

@herrhotzenplotz
Copy link
Owner

I have 0 skills written MAKE files. so i create a bash script to build it, but currently i am running it on a docker container.

A plain POSIX shell script is fine - we can maybe massage it a bit such that it can be turned into a Makefile.

You tell me how to give you the code. i am new with this kind of contributes.

You can either just send it inline in an E-Mail to our mailing list: ~herrhotzenplotz/[email protected] (probably the easiest)

... or clone the gcli repo, add the script into the tools/ directory, commit and open a pull request.

@gbowne1
Copy link

gbowne1 commented Sep 2, 2024

You can either just send it inline in an E-Mail to our mailing list: ~herrhotzenplotz/[email protected] (probably the easiest)

This reminds me @herrhotzenplotz, I made a bash script the user can run to see if they have the necessary packages/libraries installed to build/compile.. made because I don't always trust that the user knows everything including what's installed on their machine, including myself (there are so many machines).

Should I commit/PR that?

Thanks,
@gbowne1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants