From 69a7fcac1b6663814a974e07de3f4593f16dde5d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Artur=20M=C4=99dryga=C5=82?= <artur.medrygal@escolasoft.com>
Date: Fri, 29 Mar 2024 12:46:04 +0100
Subject: [PATCH 1/7] feat: improved attributes values validation

---
 .../attributes/configurator/Configurator.vue  |  7 +++-
 .../configurator/DateAndNumberTypeInput.vue   | 17 ++++++----
 .../modules/attributes/configurator/Item.vue  | 19 +++++++++--
 .../configurator/SelectTypeInput.vue          |  1 +
 src/views/products/View.vue                   | 33 +++++++++++++------
 5 files changed, 57 insertions(+), 20 deletions(-)

diff --git a/src/components/modules/attributes/configurator/Configurator.vue b/src/components/modules/attributes/configurator/Configurator.vue
index 3c8baa0c..c61a6048 100644
--- a/src/components/modules/attributes/configurator/Configurator.vue
+++ b/src/components/modules/attributes/configurator/Configurator.vue
@@ -141,7 +141,12 @@ export default defineComponent({
     },
 
     deleteAttribute(id: UUID) {
-      this.attributes = this.attributes.filter((a) => a.id !== id)
+      const removedAttribute = this.attributes.find((a) => a.id === id)
+      if (removedAttribute?.global) {
+        removedAttribute.selected_options = [undefined as any]
+      } else {
+        this.attributes = this.attributes.filter((a) => a.id !== id)
+      }
     },
   },
 })
diff --git a/src/components/modules/attributes/configurator/DateAndNumberTypeInput.vue b/src/components/modules/attributes/configurator/DateAndNumberTypeInput.vue
index 5baaf699..ff138e66 100644
--- a/src/components/modules/attributes/configurator/DateAndNumberTypeInput.vue
+++ b/src/components/modules/attributes/configurator/DateAndNumberTypeInput.vue
@@ -5,24 +5,25 @@
         v-model="selectedOption[0].value_date"
         class="date-input__input"
         type="date"
-        name="value_date"
+        :name="`${attribute.id}_value_date`"
       />
     </div>
     <div v-else-if="type === AttributeType.Number" class="number-input">
       <app-input
         :value="getOptionName(selectedOption[0])"
         class="number-input__input"
-        name="name"
+        :name="`${attribute.id}_name`"
         :label="$t('displayName').toString()"
         :placeholder="$t('namePlaceholder').toString()"
         @input="setOptionName(selectedOption[0], $event)"
       />
-      <app-input
+      <validated-input
         v-model="selectedOption[0].value_number"
         class="number-input__input"
         type="number"
-        step="0.00001"
-        name="value_number"
+        step="0.0001"
+        :name="`${attribute.id}_value_number`"
+        :rules="isRequired ? 'required' : null"
         :label="$t('value').toString()"
         :placeholder="$t('valuePlaceholder').toString()"
       />
@@ -96,6 +97,10 @@ export default defineComponent({
       },
     },
 
+    isRequired(): boolean {
+      return !!this.getOptionName(this.selectedOption[0])
+    },
+
     AttributeType(): typeof AttributeType {
       return AttributeType
     },
@@ -171,7 +176,7 @@ export default defineComponent({
 
     @media ($viewport-6) {
       max-width: 185px;
-      margin-top: -20px;
+      // margin-top: -20px;
     }
   }
 }
diff --git a/src/components/modules/attributes/configurator/Item.vue b/src/components/modules/attributes/configurator/Item.vue
index 9902be81..c533e211 100644
--- a/src/components/modules/attributes/configurator/Item.vue
+++ b/src/components/modules/attributes/configurator/Item.vue
@@ -1,5 +1,5 @@
 <template>
-  <list-item no-hover>
+  <ListItem no-hover class="product-attribute-list-item">
     <div class="product-attribute">
       <a-tooltip>
         <div class="product-attribute__title">
@@ -31,7 +31,8 @@
         </icon-button>
 
         <icon-button
-          v-if="!disabled && !attribute.global"
+          v-if="isRemovable"
+          :disabled="disabled"
           size="small"
           type="danger"
           @click="deleteAttribute(attribute.id)"
@@ -42,7 +43,7 @@
         </icon-button>
       </div>
     </template>
-  </list-item>
+  </ListItem>
 </template>
 
 <i18n lang="json">
@@ -61,6 +62,7 @@
 <script lang="ts">
 import { defineComponent, PropType } from 'vue'
 import { AttributeType, Attribute, ProductAttribute } from '@heseya/store-core'
+import isNil from 'lodash/isNil'
 
 import Empty from '@/components/layout/Empty.vue'
 import List from '@/components/layout/List.vue'
@@ -105,6 +107,13 @@ export default defineComponent({
         this.$emit('input', val)
       },
     },
+
+    isRemovable(): boolean {
+      const hasValue = this.attribute.selected_options.some(
+        (v) => !isNil(v?.value_date) || !isNil(v?.value_number),
+      )
+      return !this.attribute.global || hasValue
+    },
   },
   methods: {
     deleteAttribute(id: UUID) {
@@ -155,6 +164,10 @@ export default defineComponent({
   }
 }
 
+.product-attribute-list-item {
+  // padding: 16px 12px 16px;
+}
+
 .product-attribute {
   width: 100%;
   display: flex;
diff --git a/src/components/modules/attributes/configurator/SelectTypeInput.vue b/src/components/modules/attributes/configurator/SelectTypeInput.vue
index 53782ae9..8ab16bd8 100644
--- a/src/components/modules/attributes/configurator/SelectTypeInput.vue
+++ b/src/components/modules/attributes/configurator/SelectTypeInput.vue
@@ -10,6 +10,7 @@
       allow-clear
       :loading="isLoading"
       :placeholder="$t('placeholder').toString()"
+      :name="`${attribute.id}_value`"
       @search="onSearch"
       @input-keydown="onInputKeydown"
       @change="setValue"
diff --git a/src/views/products/View.vue b/src/views/products/View.vue
index d2591a9c..0b5ccd5b 100644
--- a/src/views/products/View.vue
+++ b/src/views/products/View.vue
@@ -1,5 +1,6 @@
 <template>
   <div :key="$route.params.id" class="product-page-wrapper">
+    <Loading :active="isLoading" />
     <AbsoluteContentLangSwitch :value="editedLang" @input="setEditedLang" />
 
     <TopNav>
@@ -46,7 +47,7 @@
       </PopConfirm>
     </TopNav>
 
-    <ValidationObserver v-slot="{ handleSubmit }">
+    <ValidationObserver ref="form">
       <form class="product-page" @submit.stop.prevent="handleSubmit(saveProduct)">
         <Card class="product-page__main">
           <h2 class="product-page__subtitle">{{ $t('baseFormTitle') }}</h2>
@@ -175,6 +176,7 @@
       "removed": "Produkt został usunięty.",
       "created": "Produkt został utworzony.",
       "updated": "Produkt został zaktualizowany.",
+      "validationError": "Formularz zawiera błędy. Uzupełnij brakujące pola.",
       "error": "Wystąpił błąd podczas zapisywania produktu.",
       "highlightedAttributeCopySuccess": "Wartość atrybutu została skopiowana!"
     },
@@ -193,6 +195,7 @@
       "removed": "Product has been removed.",
       "created": "Product has been created.",
       "updated": "Product has been updated.",
+      "validationError": "The form contains errors. Fill in the missing fields.",
       "error": "An error occurred while saving the product.",
       "highlightedAttributeCopySuccess": "Highlighted attribute value has been copied!"
     },
@@ -227,6 +230,7 @@ import ProductAttachments from '@/components/modules/products/attachments/List.v
 import ProductRelatedSets from '@/components/modules/products/related/List.vue'
 import DescriptionAccordion from '@/components/DescriptionAccordion.vue'
 import ProductBannerForm from '@/components/modules/products/BannerForm.vue'
+import Loading from '@/components/layout/Loading.vue'
 
 // import preventLeavingPage from '@/mixins/preventLeavingPage'
 
@@ -274,6 +278,7 @@ const EMPTY_FORM: ProductComponentForm = {
 
 export default defineComponent({
   components: {
+    Loading,
     TopNav,
     Gallery,
     Card,
@@ -304,6 +309,7 @@ export default defineComponent({
     }
   },
   data: () => ({
+    isLoading: false,
     editedLang: '',
     form: cloneDeep(EMPTY_FORM),
   }),
@@ -311,9 +317,6 @@ export default defineComponent({
     id(): UUID {
       return this.$route.params.id
     },
-    isLoading(): boolean {
-      return this.$accessor.products.isLoading
-    },
     isNew(): boolean {
       return this.id === 'create'
     },
@@ -383,6 +386,16 @@ export default defineComponent({
     this.setEditedLang(this.$accessor.languages.apiLanguage?.id || '')
   },
   methods: {
+    handleSubmit(callback: Function) {
+      ;(this.$refs.form as any).validate().then((success: boolean) => {
+        if (!success) {
+          this.$toast.error(this.$t('messages.validationError') as string)
+          return
+        }
+        callback()
+      })
+    },
+
     setEditedLang(langId: string) {
       this.editedLang = langId
 
@@ -395,26 +408,26 @@ export default defineComponent({
     async fetch() {
       this.form = cloneDeep(EMPTY_FORM)
       if (this.isNew) return
-      this.$accessor.startLoading()
+      this.isLoading = true
       await this.$accessor.products.get(this.$route.params.id)
 
       // isFormPrefilled should be set to true after form was prefilled
       // this.isFormPrefilled = true
 
-      this.$accessor.stopLoading()
+      this.isLoading = false
     },
     async deleteProduct() {
-      this.$accessor.startLoading()
+      this.isLoading = true
       const success = await this.$accessor.products.remove(this.id)
       if (success) {
         this.$toast.success(this.$t('messages.removed') as string)
         this.$router.push('/products')
       }
-      this.$accessor.stopLoading()
+      this.isLoading = false
     },
 
     async saveProduct() {
-      this.$accessor.startLoading()
+      this.isLoading = true
       try {
         const attributes = await updateProductAttributeOptions(
           this.form.attributes.filter((v) => v.selected_options),
@@ -479,7 +492,7 @@ export default defineComponent({
         this.$toast.error(this.$t('messages.error') as string)
       }
 
-      this.$accessor.stopLoading()
+      this.isLoading = false
     },
 
     async saveMetadata(id: string) {

From 6bff1548db510a018d0f1c4cb2d25f4e1d5ee751 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Artur=20M=C4=99dryga=C5=82?= <artur.medrygal@escolasoft.com>
Date: Fri, 29 Mar 2024 12:50:54 +0100
Subject: [PATCH 2/7] fix: code tweaks

---
 .../modules/attributes/configurator/Configurator.vue       | 1 +
 .../attributes/configurator/DateAndNumberTypeInput.vue     | 1 -
 src/components/modules/attributes/configurator/Item.vue    | 7 ++-----
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/components/modules/attributes/configurator/Configurator.vue b/src/components/modules/attributes/configurator/Configurator.vue
index c61a6048..96061f34 100644
--- a/src/components/modules/attributes/configurator/Configurator.vue
+++ b/src/components/modules/attributes/configurator/Configurator.vue
@@ -142,6 +142,7 @@ export default defineComponent({
 
     deleteAttribute(id: UUID) {
       const removedAttribute = this.attributes.find((a) => a.id === id)
+      // When Global attribute is removed, value is removed, not the attribute itself
       if (removedAttribute?.global) {
         removedAttribute.selected_options = [undefined as any]
       } else {
diff --git a/src/components/modules/attributes/configurator/DateAndNumberTypeInput.vue b/src/components/modules/attributes/configurator/DateAndNumberTypeInput.vue
index ff138e66..f61fed60 100644
--- a/src/components/modules/attributes/configurator/DateAndNumberTypeInput.vue
+++ b/src/components/modules/attributes/configurator/DateAndNumberTypeInput.vue
@@ -176,7 +176,6 @@ export default defineComponent({
 
     @media ($viewport-6) {
       max-width: 185px;
-      // margin-top: -20px;
     }
   }
 }
diff --git a/src/components/modules/attributes/configurator/Item.vue b/src/components/modules/attributes/configurator/Item.vue
index c533e211..f5ba3857 100644
--- a/src/components/modules/attributes/configurator/Item.vue
+++ b/src/components/modules/attributes/configurator/Item.vue
@@ -1,5 +1,5 @@
 <template>
-  <ListItem no-hover class="product-attribute-list-item">
+  <ListItem no-hover>
     <div class="product-attribute">
       <a-tooltip>
         <div class="product-attribute__title">
@@ -112,6 +112,7 @@ export default defineComponent({
       const hasValue = this.attribute.selected_options.some(
         (v) => !isNil(v?.value_date) || !isNil(v?.value_number),
       )
+      // Global value can be removed only if it has value (value is removed, not the attribute itself)
       return !this.attribute.global || hasValue
     },
   },
@@ -164,10 +165,6 @@ export default defineComponent({
   }
 }
 
-.product-attribute-list-item {
-  // padding: 16px 12px 16px;
-}
-
 .product-attribute {
   width: 100%;
   display: flex;

From b4d492c79d908ff32c2acd45d0afb85ab41562ae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Artur=20M=C4=99dryga=C5=82?= <artur.medrygal@escolasoft.com>
Date: Tue, 9 Apr 2024 14:35:19 +0200
Subject: [PATCH 3/7] fix: fixed pagination in products

---
 src/components/PaginatedList.vue | 4 ++--
 src/views/orders/Index.vue       | 2 ++
 src/views/products/Index.vue     | 4 +++-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/components/PaginatedList.vue b/src/components/PaginatedList.vue
index 9bf27dc8..feffb6d0 100644
--- a/src/components/PaginatedList.vue
+++ b/src/components/PaginatedList.vue
@@ -206,10 +206,10 @@ export default defineComponent({
 
       const queryFilters = formatFilters(this.filters)
       await this.$accessor[this.storeKey].fetch({
-        page: this.page,
-        limit: this.itemsPerPage,
         ...queryFilters,
         ...this.params,
+        page: this.page,
+        limit: this.itemsPerPage,
       })
 
       this.isLoading = false
diff --git a/src/views/orders/Index.vue b/src/views/orders/Index.vue
index 7f76be09..2f8ed189 100644
--- a/src/views/orders/Index.vue
+++ b/src/views/orders/Index.vue
@@ -259,6 +259,8 @@ export default defineComponent({
         (this.$route.query.digital_shipping_method_id as string) || ALL_FILTER_VALUE,
       paid: (this.$route.query.paid as string) || ALL_FILTER_VALUE,
       sort: (this.$route.query.sort as string) || '',
+      sales_channel_id: (this.$route.query.sales_channel_id as string) || ALL_FILTER_VALUE,
+      payment_method_id: (this.$route.query.payment_method_id as string) || ALL_FILTER_VALUE,
     }
   },
   methods: {
diff --git a/src/views/products/Index.vue b/src/views/products/Index.vue
index 0bdfdd98..d9006737 100644
--- a/src/views/products/Index.vue
+++ b/src/views/products/Index.vue
@@ -3,9 +3,9 @@
     <PaginatedList
       :title="$t('title').toString()"
       :filters="filters"
-      store-key="products"
       :table="listView ? tableConfig : undefined"
       :xlsx-file-config="fileConfig"
+      store-key="products"
       @search="makeSearch"
       @clear-filters="clearFilters"
     >
@@ -217,6 +217,7 @@ export default defineComponent({
 
   created() {
     Object.entries(this.$route.query).forEach(([key, value]) => {
+      if (key === 'page') return
       this.filters[key] = value as any
     })
 
@@ -244,6 +245,7 @@ export default defineComponent({
   },
   methods: {
     makeSearch(filters: ProductFilers) {
+      console.log('🚀 ~ makeSearch ~ filters:', filters)
       this.filters = filters
 
       const queryFilters = formatFilters(filters)

From 44838bc56520fb6762451b0b13b80704b5d7c59d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Artur=20M=C4=99dryga=C5=82?= <artur.medrygal@escolasoft.com>
Date: Tue, 9 Apr 2024 14:36:16 +0200
Subject: [PATCH 4/7] chore: version bump

---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index b692e324..ad610e7d 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "store-admin",
-  "version": "6.0.2",
+  "version": "6.0.3",
   "private": true,
   "description": "Admin panel for Heseya Store API",
   "author": "Heseya",

From 7037a84770e02ec7e12df71b556702a29470b386 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Artur=20M=C4=99dryga=C5=82?= <artur.medrygal@escolasoft.com>
Date: Tue, 9 Apr 2024 14:45:03 +0200
Subject: [PATCH 5/7] fix: htaccess manifest fix

---
 .htaccess | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.htaccess b/.htaccess
index 24e78f07..d11008a1 100644
--- a/.htaccess
+++ b/.htaccess
@@ -5,6 +5,7 @@ RewriteEngine on
 RewriteRule sitemap.xml sitemap.xml [L]
 RewriteRule robots.txt robots.txt [L]
 RewriteRule manifest.json manifest.json [L]
+RewriteRule manifest.webmanifest manifest.webmanifest [L]
 
 RewriteCond %{REQUEST_URI} !(\.svg|\.png|\.jpg|\.gif|\.jpeg|\.bmp|\.ico|\.css|\.js|\.txt|\.mp4|\.map|\.woff2|\.woff|\.ttf|\.eot)$
 RewriteRule (.*) index.html [QSA]

From 6676de1b957c1701f75c2910fb3475614f382fa5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Artur=20M=C4=99dryga=C5=82?= <artur.medrygal@escolasoft.com>
Date: Tue, 9 Apr 2024 15:08:25 +0200
Subject: [PATCH 6/7] chore: changed .htaccess

---
 .htaccess | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/.htaccess b/.htaccess
index d11008a1..38165cc9 100644
--- a/.htaccess
+++ b/.htaccess
@@ -1,11 +1,5 @@
-Options +FollowSymLinks +ExecCGI
-Options -MultiViews
-RewriteEngine on
-
-RewriteRule sitemap.xml sitemap.xml [L]
-RewriteRule robots.txt robots.txt [L]
-RewriteRule manifest.json manifest.json [L]
-RewriteRule manifest.webmanifest manifest.webmanifest [L]
-
-RewriteCond %{REQUEST_URI} !(\.svg|\.png|\.jpg|\.gif|\.jpeg|\.bmp|\.ico|\.css|\.js|\.txt|\.mp4|\.map|\.woff2|\.woff|\.ttf|\.eot)$
-RewriteRule (.*) index.html [QSA]
+RewriteEngine On
+RewriteBase /
+RewriteCond %{REQUEST_FILENAME} !-f
+RewriteCond %{REQUEST_FILENAME} !-d
+RewriteRule (.*) /index.html [QSA,L]

From 28a1aa209956fae76d7bceb7a4d290191f23804c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Artur=20M=C4=99dryga=C5=82?= <artur.medrygal@escolasoft.com>
Date: Wed, 10 Apr 2024 09:25:38 +0200
Subject: [PATCH 7/7] chore: error message tweak

---
 src/locales/en.json | 2 +-
 src/locales/pl.json | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/locales/en.json b/src/locales/en.json
index 20f30722..443a774c 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -224,7 +224,7 @@
       "INTERNAL_SERVER_ERROR": "Internal server error"
     },
     "CLIENT_ERROR": {
-      "ERR_NETWORK": "No internet access",
+      "ERR_NETWORK": "No internet access, or server connection error",
       "UNPROCESSABLE_ENTITY": "Unprocessable entity",
       "CDN_NOT_ALLOWED_TO_CHANGE_ALT": "You cannot change alt attribute of this image.",
       "CLIENT_INVALID_INSTALLATION_RESPONSE": "App has invalid installation response.",
diff --git a/src/locales/pl.json b/src/locales/pl.json
index f1028963..6271c9b9 100644
--- a/src/locales/pl.json
+++ b/src/locales/pl.json
@@ -224,7 +224,7 @@
       "INTERNAL_SERVER_ERROR": "Wewnętrzny błąd serwera"
     },
     "CLIENT_ERROR": {
-      "ERR_NETWORK": "Brak dostępu do internetu",
+      "ERR_NETWORK": "No internet access, or connection error to the server",
       "CLIENT_INVALID_INSTALLATION_RESPONSE": "Aplikacja ma nieprawidłową odpowiedź dotyczącą instalacji.",
       "CDN_NOT_ALLOWED_TO_CHANGE_ALT": "Nie możesz zmienić tekstu alternatywnego tego zdjęcia.",
       "CLIENT_FAILED_TO_CONNECT_WITH_APP": "Nie udało połączyć się z aplikacją.",