Patch 1 #3
Closed
Patch 1 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resaec
reviewed
Dec 12, 2019
| @@ -46,7 +46,7 @@ | |||
| * 2.2k Ohm Resistor : amzn.com/B0185FJBJC | |||
| * 3.3v Voltage Regulator : amzn.com/B0758ZTS61 | |||
| * TIP102 NPN Transistor : amzn.com/B00M1GGKIC | |||
| * 940nm LED Array : amzn.com/B00M1GGKICB07D5FJQ62 | |||
| * 940nm LED Array : amzn.com/B07D5FJQ62 | |||
There was a problem hiding this comment.
As per the talk this should say 904nm for the IR LEDs
https://www.youtube.com/watch?v=vQtLms02PFM
At the time of 28:38 on the slide and at 38:07 he corrects the value shown.
The actual amazon listing says 940nm, so there might be a mix up on one side.
There was a problem hiding this comment.
I noticed the same thing and created an issue for it. It looks like 904/905 is the correct value from my quick research. The downside is they are more expensive and harder to find than 940.
There was a problem hiding this comment.
Does this mean it will not work for just the lidar jammer, or will not work for anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1
Not sure why its saying i changed the last line...its definitely the same. but it looks like the url just had combined 2 short codes. probably a copy/paste mistake