Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarter merging #1

Open
freeman-lab opened this issue Jan 28, 2016 · 0 comments
Open

smarter merging #1

freeman-lab opened this issue Jan 28, 2016 · 0 comments

Comments

@freeman-lab
Copy link
Contributor

When we currently merge geometries inside scene here -- e.g. taking all path and center geometries that make up the platform and turning it into one geometry -- we are not discarding points or faces at the boundaries between adjacent geometries. Instead, we are just using the basic mesh-combine module, which literally concatenates all vertices and faces.

Instead, if you have e.g. two rectangles flush side by side, you want to discard all four faces and four of the eight vertices where they intersect. And just do that in general for any adjacent geometries.

The main reason we want this is to prevent the subtle but noticeable "tearing" at the boundaries. I tried some dumb things (like removing duplicate vertices after correcting for rounding) but couldn't quite get it to work.

cc @sethvincent @mathisonian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant