Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvfbc-sys: Add Windows Support #7

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

nvfbc-sys: Add Windows Support #7

wants to merge 6 commits into from

Conversation

ShayBox
Copy link

@ShayBox ShayBox commented Mar 8, 2024 •
edited
Loading

I have tested that nvfbc-sys and nvfbc build successfully on Linux, and that nvfbc-sys builds on Windows, however nvfbc is still incompatible with the Nvidia Capture SDK v7, I'm not sure how to go about supporting both v7 and v8, but the unsafe bindings should work, untested.

Related: #6 but still needs nvfbc support to close.

@hgaiser
Copy link
Owner

hgaiser commented Mar 9, 2024 via email •
edited
Loading

@hgaiser
Copy link
Owner

hgaiser commented Mar 22, 2024

Sorry for taking so long to review this. I don't think it makes sense to add Windows support if it requires quite a significant number of changes, in addition to it being officially unsupported. Any future update to the Nvidia Windows drivers might remove support for NvFBC.

@ShayBox
Copy link
Author

ShayBox commented Mar 22, 2024 •
edited
Loading

I think just adding windows support to the bindings crate is enough, you can still use it unsafe without the library wrapper.

Edit: I'll revert the library changes when I get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShayBox @hgaiser