Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for PATCH verb #33

Open
tommytusj opened this issue Sep 26, 2019 · 3 comments
Open

No support for PATCH verb #33

tommytusj opened this issue Sep 26, 2019 · 3 comments

Comments

@tommytusj
Copy link

To use the MailChimp 3.0 you have to use the method PATCH to do updates. Any reason this has not been implemented?

@tommytusj
Copy link
Author

I see you've already made the changes in this branch: https://github.com/hgoebl/DavidWebb/tree/method_PATCH any reason it wasn't merged?

@tommytusj
Copy link
Author

I tried the branch and the first thing I noticed is that PATCH is not supported by any JDK that uses HttpURLConnection.class. This workaround does work even though it's a big hack: https://stackoverflow.com/a/46323891/142824 and I got it working in your branch.

other than that there are some tests that fail now. Testing against a remote service like google maps is going to fail sooner or later. The reflection hack above requires java 1.8 so some of the plugins in maven stopped working. Had to remove them to build successfully

@hgoebl
Copy link
Owner

hgoebl commented Sep 26, 2019

If you're just starting a new project, you might consider using OkHttp instead. AFAIK some Android versions use this as an HttpUrlConnection implementation. This lib could use this natively as well, but what's the point of wrapping a very powerful and easy to use library by another and losing features?

Still, it would be an alternative to use OkHttp instead of HttpUrlConnection under the hood. Currently, I've no time to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants