HSEARCH-4989 Use a different property to skip JQAssistant analysis of…

… some modules
hibernate · Oct 13, 2023 · 225cc04 · 225cc04
1 parent 0c1ef4c
commit 225cc04
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 13 deletions.
diff --git a/build/config/pom.xml b/build/config/pom.xml
@@ -19,7 +19,7 @@
     <description>Hibernate Search common build configuration files</description>
 
     <properties>
-        <jqassistant.skip>true</jqassistant.skip>
+        <jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
 
         <!--
             This module generates the rules used in the Checkstyle and ForbiddenAPIs plugins,

diff --git a/build/enforcer/pom.xml b/build/enforcer/pom.xml
@@ -30,7 +30,7 @@
         <format.skip>true</format.skip>
 
         <deploy.skip>true</deploy.skip>
-        <jqassistant.skip>true</jqassistant.skip>
+        <jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
     </properties>
 
     <dependencies>

diff --git a/build/reports/pom.xml b/build/reports/pom.xml
@@ -21,12 +21,6 @@
     <packaging>pom</packaging>
 
     <properties>
-        <!--
-             Do NOT skip jqassistant: we want to execute analysis here so as to fail the build if anything is wrong.
-             Reminder: jqassistant only executes analysis in the last module of the build,
-             so if we skip it in the last module, it just won't execute analysis... ever.
-         -->
-        <jqassistant.skip>false</jqassistant.skip>
         <!--
         Disable the dependency convergence rule, because the dependencies of various integration tests do not converge
         -->

diff --git a/integrationtest/v5migrationhelper/engine/pom.xml b/integrationtest/v5migrationhelper/engine/pom.xml
@@ -21,7 +21,7 @@
 
     <properties>
         <!-- This is based on legacy code and there are plenty of problems that we don't care to fix -->
-        <jqassistant.skip>true</jqassistant.skip>
+        <jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
         <forbiddenapis.skip>true</forbiddenapis.skip>
         <sonar.skip>true</sonar.skip>
     </properties>

diff --git a/integrationtest/v5migrationhelper/orm/pom.xml b/integrationtest/v5migrationhelper/orm/pom.xml
@@ -21,7 +21,7 @@
 
     <properties>
         <!-- This is based on legacy code and there are plenty of problems that we don't care to fix -->
-        <jqassistant.skip>true</jqassistant.skip>
+        <jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
         <forbiddenapis.skip>true</forbiddenapis.skip>
         <sonar.skip>true</sonar.skip>
 

diff --git a/util/internal/integrationtest/v5migrationhelper/pom.xml b/util/internal/integrationtest/v5migrationhelper/pom.xml
@@ -21,7 +21,7 @@
 
     <properties>
         <!-- This is based on legacy code and there are plenty of problems that we don't care to fix -->
-        <jqassistant.skip>true</jqassistant.skip>
+        <jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
         <forbiddenapis.skip>true</forbiddenapis.skip>
         <sonar.skip>true</sonar.skip>
     </properties>

diff --git a/v5migrationhelper/engine/pom.xml b/v5migrationhelper/engine/pom.xml
@@ -25,7 +25,7 @@
         <java.module.name>org.hibernate.search.v5migrationhelper.engine</java.module.name>
 
         <!-- This is based on legacy code and there are plenty of problems that we don't care to fix -->
-        <jqassistant.skip>true</jqassistant.skip>
+        <jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
         <forbiddenapis.skip>true</forbiddenapis.skip>
         <sonar.skip>true</sonar.skip>
     </properties>

diff --git a/v5migrationhelper/orm/pom.xml b/v5migrationhelper/orm/pom.xml
@@ -25,7 +25,7 @@
         <java.module.name>org.hibernate.search.v5migrationhelper.orm</java.module.name>
 
         <!-- This is based on legacy code and there are plenty of problems that we don't care to fix -->
-        <jqassistant.skip>true</jqassistant.skip>
+        <jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
         <forbiddenapis.skip>true</forbiddenapis.skip>
         <sonar.skip>true</sonar.skip>
     </properties>