HSEARCH-4989 Use a different property to skip JQAssistant analysis of some modules #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
yrodiere
approved these changes
Oct 12, 2023
|
hmm Oracle container timed out this time 😔, which looks unrelated, but it's a few times now that containers are timing out (Postgres, Elasticsearch, now Oracle...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-4989
The problem was coming from how the plugin decides if it is the last module in the execution run ... it expects to encounter all the modules, even those that skip plugin execution... but it still wants to see them as "executed" which never happens 😃 ...
using this other property
jqassistant.maven.module.skipallows skipping the analysis of the module, which makes the plugin happy and it manages to correctly figure out when to run the analysis..I have also looked into the rule for nested static class ... but the info is not there. from what it seems ASM does not add a static modifier to the descriptor and that field is never set to true in the generated DB, there's also no other info that can be used to cover that sooo I've just added another check into the filter in the JUnit upgrade PR...