Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue links not getting synced #77

Closed
marko-bekhta opened this issue Dec 6, 2024 · 2 comments
Closed

Issue links not getting synced #77

marko-bekhta opened this issue Dec 6, 2024 · 2 comments

Comments

@marko-bekhta
Copy link
Member

I've noticed a few logs as:

"POST /api/jira/webhooks/?triggeredByUser=bla-bla-bla HTTP/1.1" 404 53
"POST /api/jira/webhooks/?triggeredByUser=bla-bla-bla HTTP/1.1" 404 53
"POST /api/jira/webhooks/?triggeredByUser=bla-bla-bla HTTP/1.1" 404 53
"POST /api/jira/webhooks/?triggeredByUser=bla-bla-bla HTTP/1.1" 404 53

Where the project key is missing from the POST URL. And from what I've found so far: adding/updating issue links triggers that kind of event. My guess is that the webhook cannot figure out the {{project.key}} when triggering this, resulting in a missing project key 😕

I guess we have two options:

  • we either create a hook per project and hardcode the project key in the URL
  • we update the app so that the project key is not required for the link events.

@yrodiere, which option would you prefer? 😃

@yrodiere
Copy link
Member

yrodiere commented Dec 6, 2024

I've always wondered why the project key needed to be part of the webhook, since it's most likely part of the request body...

I'd just resolve the project key from the request body as a fallback?

@marko-bekhta
Copy link
Member Author

This should be addressed now by #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants