From c4cfb5443f5336c34533557675c9f2339c533105 Mon Sep 17 00:00:00 2001
From: Collin Bolles <collinbolles@gmail.com>
Date: Fri, 22 Nov 2024 18:18:56 -0500
Subject: [PATCH] bug: NERC Execution (#19)

* Ensure sim files are made
* Make errors easier to follow
---
 packages/backend/src/job/job.service.ts       |  3 +-
 .../src/simulation/simulation.consumer.ts     | 39 +++++++++----------
 packages/runner/Dockerfile                    |  2 +
 3 files changed, 23 insertions(+), 21 deletions(-)

diff --git a/packages/backend/src/job/job.service.ts b/packages/backend/src/job/job.service.ts
index cc0c633..3d402ed 100644
--- a/packages/backend/src/job/job.service.ts
+++ b/packages/backend/src/job/job.service.ts
@@ -65,7 +65,8 @@ export class JobService {
         { name: 'REDIS_PORT', value: this.configService.getOrThrow<string>('redis.jobPort') },
         { name: 'REDIS_PASSWORD', value: this.configService.get<string>('redis.jobPassword') },
         { name: 'COMETS_GLOP', value: './lib/comets_glop' }
-      ]
+      ],
+      imagePullPolicy: 'Always'
     });
     this.jobTemplate.spec.template.spec.restartPolicy = 'Never';
     this.jobTemplate.spec.backoffLimit = 0;
diff --git a/packages/backend/src/simulation/simulation.consumer.ts b/packages/backend/src/simulation/simulation.consumer.ts
index b11e195..270f5ba 100644
--- a/packages/backend/src/simulation/simulation.consumer.ts
+++ b/packages/backend/src/simulation/simulation.consumer.ts
@@ -13,19 +13,14 @@ export class SimulationRequestConsumer extends WorkerHost {
   async process(job: Job<SimulationRequest, any, string>): Promise<any> {
     const request = job.data;
     // Start the COMETs job
-    try {
-      const jobName = await this.jobService.triggerJob(request);
-      // Wait for the job to complete
-      const status = await this.awaitCompletion(jobName);
-      // If the status is error, collect and send error data
-      if (status == JobStatus.FAILURE) {
-        await this.handleError(request, jobName);
-      } else {
-        await this.handleSuccess(request, jobName);
-      }
-    } catch (e) {
-      console.error(e);
-      throw e;
+    const jobName = await this.jobService.triggerJob(request);
+    // Wait for the job to complete
+    const status = await this.awaitCompletion(jobName);
+    // If the status is error, collect and send error data
+    if (status == JobStatus.FAILURE) {
+      await this.handleError(request, jobName);
+    } else {
+      await this.handleSuccess(request, jobName);
     }
   }
 
@@ -50,14 +45,18 @@ export class SimulationRequestConsumer extends WorkerHost {
    * Keep checking the status of the job once a second
    */
   private async awaitCompletion(jobName: string): Promise<JobStatus> {
-    return new Promise(async (resolve, _reject) => {
+    return new Promise(async (resolve, reject) => {
       const checkOperations = async () => {
-        const status = await this.jobService.getJobStatus(jobName);
-        if (status == JobStatus.RUNNING) {
-          setTimeout(checkOperations, 1000);
-          return;
-        } else {
-          resolve(status);
+        try {
+          const status = await this.jobService.getJobStatus(jobName);
+          if (status == JobStatus.RUNNING) {
+            setTimeout(checkOperations, 1000);
+            return;
+          } else {
+            resolve(status);
+          }
+        } catch (e) {
+          reject(e);
         }
       };
       await checkOperations();
diff --git a/packages/runner/Dockerfile b/packages/runner/Dockerfile
index ef18af5..63bcf6f 100644
--- a/packages/runner/Dockerfile
+++ b/packages/runner/Dockerfile
@@ -17,4 +17,6 @@ ENV PYTHONUNBUFFERED=1
 
 RUN pip3 install --no-cache-dir -r requirements.txt
 
+RUN mkdir sim_files/
+
 ENTRYPOINT ["python3", "main.py"]