Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate outlines for symbols using SDF #84

Closed
hiddewie opened this issue Aug 3, 2024 · 2 comments
Closed

Generate outlines for symbols using SDF #84

hiddewie opened this issue Aug 3, 2024 · 2 comments

Comments

@hiddewie
Copy link
Owner

hiddewie commented Aug 3, 2024 •
edited
Loading

From

OpenRailwayMap-vector/proxy/js/styles.mjs

Line 2174 in 85dbbaf

// TODO https://github.com/maplibre/martin/issues/1075

Ref maplibre/martin#1075 and https://docs.mapbox.com/help/troubleshooting/using-recolorable-images-in-mapbox-maps/#using-sdf-enabled-images

Using SDF sprites will allow defining outlines.

Problem: currently symbols are multi-color. Possible solution is to layer two symbols on top of each other with overlap, one an SDF symbol with outline, the other multi-color static icon.

This also allows hover styles for all icons.
@hiddewie hiddewie mentioned this issue Oct 20, 2024
Merged
hiddewie added a commit that referenced this issue Oct 20, 2024
@hiddewie
Preferred direction (#121)
257feb3 
Fixes #67

After #84 is
implemented, the icons can become the color of the railway line,
blending in better.


![image](https://github.com/user-attachments/assets/b3a508af-0fc6-4112-83eb-1b218fbb1cc8)


![image](https://github.com/user-attachments/assets/b022d79d-71e9-492d-8aa6-8c4302e84450)


![image](https://github.com/user-attachments/assets/c04c54ad-c072-4623-988e-f6322876bd84)
@hiddewie
Copy link
Owner Author

maplibre/martin#1492 implements this in Martin

@hiddewie
Copy link
Owner Author

maplibre/martin#1492 is merged, and this is implemented in #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hiddewie