Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jaxb-tools vs hisrc-basicjaxb (org.patrodyne.jvnet) #450

Closed
mrpiggi opened this issue Nov 10, 2023 · 15 comments
Closed

jaxb-tools vs hisrc-basicjaxb (org.patrodyne.jvnet) #450

mrpiggi opened this issue Nov 10, 2023 · 15 comments
Labels

Comments

@mrpiggi
Copy link

mrpiggi commented Nov 10, 2023

I have already asked the question on SO, but unfortunately did not received an answer. That's why I'm trying my luck here.

Besides your project there is also hisrc-basicjaxb. Are you aware of this? Would it possibly make sense to join forces and merge the two projects back into one, or to endeavor to work together? It would be a real shame if resources were wasted and two projects with the same goal ended up existing in parallel.

@mrpiggi
Copy link
Author

mrpiggi commented Nov 10, 2023

Opened patrodyne/hisrc-basicjaxb#14 as well.

@laurentschoelens
Copy link
Collaborator

Hi @mrpiggi
Sorry I'm not watching SO (maybe I should check sometimes on questions regarding this plugin now)

I've seen what has been done and I'm already in contact with phax (which you named Philip Helger) and he's looking at our recent work.
I'm not aware of what has been done under patrodyne and don't know him neither.

Our goal with Matt was (and still is) to maintain the original repository (in fact repositories but we did merge the related jaxb-tools into this one), which both projects you mention are forked from.
We're not closed to any PR from anyone. It'd be easier to maintain only one repo, and since now we have active dev here, maybe it'd be a good start, but I don't want to force anyone to choose one repository or another : everyone's work is valuable and what phax and patrodyne did helped people when Alexey passed away (sadly)

@laurentschoelens
Copy link
Collaborator

Related issue phax#13

@mattrpav
Copy link
Collaborator

@laurentschoelens comment captured my thoughts as well. Anyone is welcome to participate or use whichever implementation they wish. A great part of open source is that there can be options!

@mrpiggi
Copy link
Author

mrpiggi commented Nov 10, 2023

I've seen what has been done and I'm already in contact with phax (which you named Philip Helger) and he's looking at our recent work. Related issue phax#13

So this was something, I was not aware of ;)

I'm not aware of what has been done under patrodyne and don't know him neither.

The same probably applied to @patrodyne, but hopefully no any longer.

Our goal with Matt was (and still is) to maintain the original repository (in fact repositories but we did merge the related jaxb-tools into this one), which both projects you mention are forked from.

Sounds great. And I am glad you took the effort and managed to merge all related repositories into this one. It really was a mess, at least from a user perspective.

We're not closed to any PR from anyone. It'd be easier to maintain only one repo, and since now we have active dev here, maybe it'd be a good start, but I don't want to force anyone to choose one repository or another : everyone's work is valuable and what phax and patrodyne did helped people when Alexey passed away (sadly)

This was exactly my intention. If anyone involved decides, for whatever reason, to continue to maintain their own fork, that is completely legitimate. I just wanted to prevent things from unintentionally splitting up.

@mrpiggi
Copy link
Author

mrpiggi commented Nov 11, 2023

@patrodyne has replied and unfortunately intends not to collaborate but to work in parallel. At least that has now been clarified.

@mrpiggi mrpiggi closed this as completed Nov 11, 2023
@laurentschoelens
Copy link
Collaborator

Seen the answer.

I'm waiting for phax review of current state of the jaxb-tools repository (he'll do it when having some time to proceed)

@laurentschoelens
Copy link
Collaborator

laurentschoelens commented Nov 11, 2023

I've also taken some time to go to SO to look at some other questions regarding maven-jaxb2-plugin and related tools.
Feel free to update your question there too 😉

@laurentschoelens
Copy link
Collaborator

@mrpiggi : updated answer on SO and also here too :

With @phax's final review on current state of the plugin, he decided to archive is own repository and to use highsouce/jaxb-tools

Added corresponding section to the migration guide - Migration from phax/maven-jaxb2-plugin

@mrpiggi
Copy link
Author

mrpiggi commented Jan 8, 2024

@laurentschoelens Many thanks for the update. Currently , I am still using patrodyne/hisrc-basicjaxb but as I want to update from Java 17 to Java 21 in the near future, I will have a look to migrate (back) to jaxb-tools.

If there are any problems, I will reach back to you. I will try to document the migration process in order to provide a migration guide like you did for phax/maven-jaxb2-plugin/

@laurentschoelens
Copy link
Collaborator

You're welcome @mrpiggi 😉
It's not mentionned (yet) but our build is running also with JDK21 in the github workflow so it's tested with JDK21 too 😄

@laurentschoelens
Copy link
Collaborator

@laurentschoelens Many thanks for the update. Currently , I am still using patrodyne/hisrc-basicjaxb but as I want to update from Java 17 to Java 21 in the near future, I will have a look to migrate (back) to jaxb-tools.

If there are any problems, I will reach back to you. I will try to document the migration process in order to provide a migration guide like you did for phax/maven-jaxb2-plugin/

Hi @mrpiggi, did you use jaxb-tools in the end ?

@mrpiggi
Copy link
Author

mrpiggi commented Aug 29, 2024

Not yet, still waiting for #433 as I am rather reluctant to additional runtime dependencies and want the generated classes to differ least possible.

@laurentschoelens
Copy link
Collaborator

Not yet, still waiting for #433 as I am rather reluctant to additional runtime dependencies and want the generated classes to differ least possible.

I'll try to work on this now since we got 2.x and 3.x finally out 😄

@mrpiggi
Copy link
Author

mrpiggi commented Aug 29, 2024

I'll try to work on this now since we got 2.x and 3.x finally out 😄

Great to hear although migration is currently no urgent task for me. So, you don't have to hurry, at least from my side ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants