Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep DNP/NOPOP in output with Qty=0 and column DNP #358

Closed
mdeweerd opened this issue May 24, 2019 · 3 comments
Closed

Keep DNP/NOPOP in output with Qty=0 and column DNP #358

mdeweerd opened this issue May 24, 2019 · 3 comments
Labels
feature-request New features resquested.

Comments

@mdeweerd
Copy link
Contributor

To make sure that no component was forgotten during the analysis, it is common practice to also list the DNP/NOPOP components in the BOM file on separate lines with quantity 0 and a DNP/NOPOP mention somewhere.

So the feature would be to group all DNP/NOPOP components at the end of the list - with Qty 0 and possibly with the pricing info (not required).
Qty 0 is already an indication that the component is not mounted, but an extra DNP column may be usefull for some.

@hildogjr hildogjr added the feature-request New features resquested. label May 24, 2019
@hildogjr hildogjr added this to the 1.2 milestone May 24, 2019
@hildogjr
Copy link
Owner

hildogjr commented May 24, 2019

First study:
This should be activated by a --show_dnp and may be required some changes in the group routines. Also some implementation to make sure that will be show at the end of the spreadsheet.
(Files to be modified: each BOM read module, spreadsheet.py order and group routine).

A important question is: if one DNP part is grouped with other of same kind but that have to be assembled?

@hildogjr hildogjr modified the milestones: 1.2, Group improvement May 21, 2020
@hildogjr
Copy link
Owner

Needed #359 fix for not workaround.

@mdeweerd
Copy link
Contributor Author

Stale, closing (limiting my issue backlog).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New features resquested.
Projects
None yet
Development

No branches or pull requests

2 participants