-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to skip or add a nice message to the user when trying to access services like Kitspace? #417
Comments
I cant use the GUI, so, does kicost has any flag to help here? |
I always run with The number of requests to Kitspace is shared amongst the users. |
So let me understand this better. I can't run this many times in a short period of time because of the limitations of the service itself. So, a user-friendly message saying the server wont handle more requests would be nice when running this tool, instead of just trying forever and dying at the end.
Cool, thanks. I was testing this flag yesterday to go over the issue and it helped to at least find and debug my setup. Also, I am thinking here since this tool is so dependable of the requests, why not do the other way around where the default is to be |
Yes, we need some code revision for warning and error messages. I did some in past but stil missing a lot. KiCost emerged a cost tool the |
I understand that the core of the kicost tool is pricing, but at the same time I think it is wise to lmiit resource usage. |
You got my point. Thanks. This message at the end saying the following would be really good agree too.
For instance, yesterday I was working to debug some functionalities of this tool and using it for the first time. I was also testing the stable version 1.1.4 and the version from the master. Today, when I finally got the tools and my project working I can't even have a quotation since the Kitspace does not reply to the Kicost. Now, I know this |
Is there an insight how many requests are available and in the pool? |
This is a question for @kasbah and I have another: About the And about the stack trace: Now KiCost shows a red error and no stack trace. So the main issue here (friendly message) is solved. If KitSpace can report 429 this will be much better. |
The pool is currently 5000 requests per month. We don't yet give a proper response when we hit the limit. We just error and then let it timeout. The most relevant code in our API is here. I've not gotten around to adding the the ability to give a proper response there. |
Sure, @set-soft if the tool works every time the user will use it, I agree. But since the tool does not work anymore after a couple of tries, this can be an issue. This happened was for me when trying to use it for the first time. Since I was testing and experimenting to make it work, I had to run it too many times. And then I realized that right after being able to use it, I could not use it anymore since I could not make more requests to that server. This may also be a problem if you are working in a place where you have many people using the tool and you just have a single external IP, as a normal company is. The idea for an inverted flag is just to make sure you will be able to run when needed. |
Well, this can be right. This issue was created one year ago. |
What do you mean by "this can be right" ? |
This means that @set-soft might be right assuming that because I have no idea why it was not working for me after using for a couple of times that time. |
Actually, one thing about kicost is the price... Getting nices BOMs with the variants feature is a pretty strong feature as well.
|
I created the regression tests without this problem. And they are far more than a couple ;-) Lamentably Octopart asks for a credit card to give a free key. I don't want to take the risk of being "accidentally" charged, so I didn't asked for a free key. But you can try it. They give 500 queries a month for free. Another option to offload KitSpace could be the implementation of the APIs for the major distributors. Digi-key provides a free key with 1000 queries by day this is more than enough for regular use. The API is already implemented in Python https://github.com/peeter123/digikey-api I'm doing a lot of work on KiCost and I'm very delayed with the KiBot integration, so I can't say I'll add Digi-Key support. We can try adding a warning, enabled by default and disabled using an environment variable (or a command line option for people too lazy to define environment variables). Hey @hildogjr ! What do you think about such a warning? Something like
|
Thanks for the info
I don't know enough Java Script to help with it. If you manage to reply 429 just tell me and I'll add a nice message to KiCost explianing the probem. |
Using v1.1.5
The text was updated successfully, but these errors were encountered: