Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT metadata processing is not enabled on testnet #1501

Closed
1 task done
wbnns opened this issue Dec 23, 2022 · 8 comments
Closed
1 task done

FT metadata processing is not enabled on testnet #1501

wbnns opened this issue Dec 23, 2022 · 8 comments
Assignees
Labels
bug Something isn't working testnet

Comments

@wbnns
Copy link

wbnns commented Dec 23, 2022

Describe the bug

Related: #1222, Trust-Machines/multisafe#29

When working with testnet, the API does not return token-uri information for FTs, regardless of whether an FT has a token-uri defined

Hiro Wallet on Testnet:

Screenshot from 2022-12-22 23-36-35

MultiSafe on Testnet:

Screenshot from 2022-12-22 23-31-54

Steps To Reproduce

  • Deploy an FT and define a standard token-uri, e.g. https://wrapped.com/xbtc.json
  • Sent a balance of the FT and observe that metadata is incorrectly populated in applications like Hiro Wallet and MultiSafe

Expected behavior

Stacks testnet should read token-uris just like it does on mainnet, otherwise it is not possible to accurately test prior to deployment on mainnet.


Minor, Non-launch blocking bugs

Minor bugs

  • Bugs in non-critical software (CLI, UI, etc) that doesn’t impact critical functionality
@wbnns wbnns added bug Something isn't working testnet labels Dec 23, 2022
@blockstack-devops blockstack-devops moved this to Recent issues in API Board Dec 23, 2022
@wbnns
Copy link
Author

wbnns commented Dec 23, 2022

An additional note of elaboration as to the root of this issue:

$ curl https://stacks-node-api.testnet.stacks.co/extended/v1/tokens/ST2TZK01NKDC89J6TA56SA47SDF7RTHYEQ42CGN7F.Wrapped-USD/ft/metadata
{
  "error": "FT metadata processing is not enabled on this server"
}

H/T: @perplexedpigmy

@wbnns wbnns changed the title API doesn't return token-uri information on testnet FT metadata processing is not enabled on testnet Dec 23, 2022
@zone117x
Copy link
Member

zone117x commented Jan 3, 2023

@rafaelcr could you give some context here? Are we intending to leave this disabled, and folks should use the new token metadata service once available?

We disable this a month ago #1482

@rafaelcr
Copy link
Collaborator

rafaelcr commented Jan 5, 2023

@zone117x the idea is to migrate users to the new service once available, but I think we should still fix #1482 so we can provide backwards compatibility for as long as possible.

I'm working on the underlying issue and will provide updates here ASAP

@rafaelcr rafaelcr moved this from Recent issues to In Development in API Board Jan 13, 2023
@rafaelcr rafaelcr moved this from In Development to Blocked in API Board Jan 19, 2023
@FriendsFerdinand
Copy link

Why is this blocked? I feel like this is required to test applications before they are on mainnet.

@saralab
Copy link
Contributor

saralab commented Mar 3, 2023

@deantchi Can we re-enable FT metadata on Testnet? The underlying issue has been fixed, we need to flip the switch.
cc: @rafaelcr

@rafaelcr
Copy link
Collaborator

while we continue to work on this issue, please know that we've already released the Token Metadata API which has support for all testnet tokens (not just FTs), for example: https://api.testnet.hiro.so/metadata/ft/ST2TZK01NKDC89J6TA56SA47SDF7RTHYEQ42CGN7F.Wrapped-USD

See docs here if you'd like to migrate https://docs.hiro.so/metadata
We plan to eventually remove this old FT metadata parser from the Stacks API once enough developers have migrated to the new one

@rafaelcr
Copy link
Collaborator

This is now solved @FriendsFerdinand @wbnns
Thanks for your patience

@github-project-automation github-project-automation bot moved this from Blocked to Done in API Board Mar 14, 2023
@wbnns
Copy link
Author

wbnns commented Mar 15, 2023

@rafaelcr Thank you all for taking care of this. 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testnet
Projects
Archived in project
Development

No branches or pull requests

6 participants