Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenMetadata client missing fetchApi config #193

Closed
kyranjamie opened this issue Jan 15, 2024 · 1 comment · Fixed by #274
Closed

TokenMetadata client missing fetchApi config #193

kyranjamie opened this issue Jan 15, 2024 · 1 comment · Fixed by #274
Labels

Comments

@kyranjamie
Copy link

kyranjamie commented Jan 15, 2024

The auto-generated JS API client doesn't support a custom fetchApi for the @hirosystems/token-metadata-api-client, as it does with the other APIs.

e.g.

// node_modules/@hirosystems/token-metadata-api-client/dist/configuration.d.ts
export interface ConfigurationParameters {
    apiKey?: string | ((name: string) => string);
    username?: string;
    password?: string;
    accessToken?: string | ((name: string, scopes?: string[]) => string);
    basePath?: string;
}

vs other packages in @stacks/blockchain-api-client which do support the fetchApi argument in their Configuration.

Being unable to override the fetch function prohibits clients from being able to monitor and modify requests, e.g. to add API key headers etc.

@zone117x zone117x transferred this issue from hirosystems/stacks-blockchain-api Jan 15, 2024
@smcclellan smcclellan moved this from 🆕 New to 📋 Backlog in API Board Jan 16, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in API Board Oct 14, 2024
@blockstack-devops
Copy link

🎉 This issue has been resolved in version 1.1.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants