redis: restruct dirs #114
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
9 errors and 4 warnings
question mark operator is useless here:
hitbox-backend/src/serializer.rs#L108
error: question mark operator is useless here
--> hitbox-backend/src/serializer.rs:108:9
|
108 | / Ok(serde_json::to_string(&serializable_value)
109 | | .map_err(|err| SerializerError::Serialize(Box::new(err)))?)
| |_______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
help: try removing question mark and `Ok()`
|
108 ~ serde_json::to_string(&serializable_value)
109 + .map_err(|err| SerializerError::Serialize(Box::new(err)))
|
|
useless conversion to the same type: `T`:
hitbox-backend/src/serializer.rs#L95
error: useless conversion to the same type: `T`
--> hitbox-backend/src/serializer.rs:95:13
|
95 | cached_value.data.into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cached_value.data`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
question mark operator is useless here:
hitbox-backend/src/serializer.rs#L79
error: question mark operator is useless here
--> hitbox-backend/src/serializer.rs:79:9
|
79 | / Ok(serde_json::to_vec(&serializable_value)
80 | | .map_err(|err| SerializerError::Serialize(Box::new(err)))?)
| |_______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
= note: `-D clippy::needless-question-mark` implied by `-D warnings`
help: try removing question mark and `Ok()`
|
79 ~ serde_json::to_vec(&serializable_value)
80 + .map_err(|err| SerializerError::Serialize(Box::new(err)))
|
|
useless conversion to the same type: `T`:
hitbox-backend/src/serializer.rs#L66
error: useless conversion to the same type: `T`
--> hitbox-backend/src/serializer.rs:66:13
|
66 | cached_value.data.into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cached_value.data`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
|
associated function `new` is never used:
hitbox-backend/src/serializer.rs#L40
error: associated function `new` is never used
--> hitbox-backend/src/serializer.rs:40:12
|
39 | impl<U> SerializableCachedValue<U> {
| ---------------------------------- associated function in this implementation
40 | pub fn new(data: U, expired: DateTime<Utc>) -> Self {
| ^^^
|
= note: `-D dead-code` implied by `-D warnings`
|
unused variable: `cached`:
hitbox-backend/src/response.rs#L67
error: unused variable: `cached`
--> hitbox-backend/src/response.rs:67:26
|
67 | async fn from_cached(cached: Self::Cached) -> Self {
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cached`
|
= note: `-D unused-variables` implied by `-D warnings`
|
unused imports: `CachePolicy`, `CacheableResponse`:
hitbox-backend/src/serializer.rs#L5
error: unused imports: `CachePolicy`, `CacheableResponse`
--> hitbox-backend/src/serializer.rs:5:16
|
5 | response::{CachePolicy, CacheableResponse},
| ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
|
unused imports: `StreamExt`, `stream`:
hitbox-backend/src/response.rs#L5
error: unused imports: `StreamExt`, `stream`
--> hitbox-backend/src/response.rs:5:15
|
5 | use futures::{stream, StreamExt};
| ^^^^^^ ^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
|
security_audit
Critical vulnerabilities were found, marking check as failed
|
security_audit
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/audit-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
security_audit
1 vulnerabilities found!
|
security_audit
1 warnings found!
|
security_audit
Unknown warning kind unsound found, please, file a bug
|