Tarantool Backend #273

Triggered via pull request August 13, 2023 23:18

lowitea

synchronize #82

tarantool

Status Failure

Total duration 1m 56s

Artifacts –

CI.yml

on: pull_request

Matrix: check

clippy

37s

Matrix: test

Annotations

15 errors and 26 warnings

question mark operator is useless here: hitbox-backend/src/serializer.rs#L140

error: question mark operator is useless here --> hitbox-backend/src/serializer.rs:140:9 | 140 | / Ok(bincode::serialize(&serializable_value) 141 | | .map_err(|err| SerializerError::Serialize(Box::new(err)))?) | |_______________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 140 ~ bincode::serialize(&serializable_value) 141 + .map_err(|err| SerializerError::Serialize(Box::new(err))) |

useless conversion to the same type: `T`: hitbox-backend/src/serializer.rs#L127

error: useless conversion to the same type: `T` --> hitbox-backend/src/serializer.rs:127:13 | 127 | cached_value.data.into(), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cached_value.data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

question mark operator is useless here: hitbox-backend/src/serializer.rs#L106

error: question mark operator is useless here --> hitbox-backend/src/serializer.rs:106:9 | 106 | / Ok(serde_json::to_string(&serializable_value) 107 | | .map_err(|err| SerializerError::Serialize(Box::new(err)))?) | |_______________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 106 ~ serde_json::to_string(&serializable_value) 107 + .map_err(|err| SerializerError::Serialize(Box::new(err))) |

useless conversion to the same type: `T`: hitbox-backend/src/serializer.rs#L93

error: useless conversion to the same type: `T` --> hitbox-backend/src/serializer.rs:93:13 | 93 | cached_value.data.into(), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cached_value.data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

question mark operator is useless here: hitbox-backend/src/serializer.rs#L77

error: question mark operator is useless here --> hitbox-backend/src/serializer.rs:77:9 | 77 | / Ok(serde_json::to_vec(&serializable_value) 78 | | .map_err(|err| SerializerError::Serialize(Box::new(err)))?) | |_______________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `-D clippy::needless-question-mark` implied by `-D warnings` help: try removing question mark and `Ok()` | 77 ~ serde_json::to_vec(&serializable_value) 78 + .map_err(|err| SerializerError::Serialize(Box::new(err))) |

useless conversion to the same type: `T`: hitbox-backend/src/serializer.rs#L64

error: useless conversion to the same type: `T` --> hitbox-backend/src/serializer.rs:64:13 | 64 | cached_value.data.into(), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cached_value.data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings`

associated function `new` is never used: hitbox-backend/src/serializer.rs#L39

error: associated function `new` is never used --> hitbox-backend/src/serializer.rs:39:12 | 38 | impl<U> SerializableCachedValue<U> { | ---------------------------------- associated function in this implementation 39 | pub fn new(data: U, expired: DateTime<Utc>) -> Self { | ^^^ | = note: `-D dead-code` implied by `-D warnings`

unused variable: `cached`: hitbox-backend/src/response.rs#L67

error: unused variable: `cached` --> hitbox-backend/src/response.rs:67:26 | 67 | async fn from_cached(cached: Self::Cached) -> Self { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cached` | = note: `-D unused-variables` implied by `-D warnings`

unused imports: `CachePolicy`, `CacheableResponse`: hitbox-backend/src/serializer.rs#L4

error: unused imports: `CachePolicy`, `CacheableResponse` --> hitbox-backend/src/serializer.rs:4:16 | 4 | response::{CachePolicy, CacheableResponse}, | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^

unused imports: `StreamExt`, `stream`: hitbox-backend/src/response.rs#L5

error: unused imports: `StreamExt`, `stream` --> hitbox-backend/src/response.rs:5:15 | 5 | use futures::{stream, StreamExt}; | ^^^^^^ ^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings`

clippy

Clippy had exited with the 101 exit code

check (stable): hitbox/src/fsm/future.rs#L60

trait takes 0 generic arguments but 1 generic argument was supplied

check (stable): hitbox/src/fsm/future.rs#L60

the value of the associated type `Subject` (from trait `Predicate`) must be specified

check (stable)

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

check (1.60.0)

The operation was canceled.

clippy

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/