redis: restruct dirs #114
clippy
8 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 8 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.71.1 (eb26296b5 2023-08-03)
- cargo 1.71.1 (7f1d04c00 2023-07-29)
- clippy 0.1.71 (eb26296 2023-08-03)
Annotations
Check failure on line 109 in hitbox-backend/src/serializer.rs
github-actions / clippy
question mark operator is useless here
error: question mark operator is useless here
--> hitbox-backend/src/serializer.rs:108:9
|
108 | / Ok(serde_json::to_string(&serializable_value)
109 | | .map_err(|err| SerializerError::Serialize(Box::new(err)))?)
| |_______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
help: try removing question mark and `Ok()`
|
108 ~ serde_json::to_string(&serializable_value)
109 + .map_err(|err| SerializerError::Serialize(Box::new(err)))
|
Check failure on line 95 in hitbox-backend/src/serializer.rs
github-actions / clippy
useless conversion to the same type: `T`
error: useless conversion to the same type: `T`
--> hitbox-backend/src/serializer.rs:95:13
|
95 | cached_value.data.into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cached_value.data`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check failure on line 80 in hitbox-backend/src/serializer.rs
github-actions / clippy
question mark operator is useless here
error: question mark operator is useless here
--> hitbox-backend/src/serializer.rs:79:9
|
79 | / Ok(serde_json::to_vec(&serializable_value)
80 | | .map_err(|err| SerializerError::Serialize(Box::new(err)))?)
| |_______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
= note: `-D clippy::needless-question-mark` implied by `-D warnings`
help: try removing question mark and `Ok()`
|
79 ~ serde_json::to_vec(&serializable_value)
80 + .map_err(|err| SerializerError::Serialize(Box::new(err)))
|
Check failure on line 66 in hitbox-backend/src/serializer.rs
github-actions / clippy
useless conversion to the same type: `T`
error: useless conversion to the same type: `T`
--> hitbox-backend/src/serializer.rs:66:13
|
66 | cached_value.data.into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cached_value.data`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
Check failure on line 40 in hitbox-backend/src/serializer.rs
github-actions / clippy
associated function `new` is never used
error: associated function `new` is never used
--> hitbox-backend/src/serializer.rs:40:12
|
39 | impl<U> SerializableCachedValue<U> {
| ---------------------------------- associated function in this implementation
40 | pub fn new(data: U, expired: DateTime<Utc>) -> Self {
| ^^^
|
= note: `-D dead-code` implied by `-D warnings`
Check failure on line 67 in hitbox-backend/src/response.rs
github-actions / clippy
unused variable: `cached`
error: unused variable: `cached`
--> hitbox-backend/src/response.rs:67:26
|
67 | async fn from_cached(cached: Self::Cached) -> Self {
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cached`
|
= note: `-D unused-variables` implied by `-D warnings`
Check failure on line 5 in hitbox-backend/src/serializer.rs
github-actions / clippy
unused imports: `CachePolicy`, `CacheableResponse`
error: unused imports: `CachePolicy`, `CacheableResponse`
--> hitbox-backend/src/serializer.rs:5:16
|
5 | response::{CachePolicy, CacheableResponse},
| ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
Check failure on line 5 in hitbox-backend/src/response.rs
github-actions / clippy
unused imports: `StreamExt`, `stream`
error: unused imports: `StreamExt`, `stream`
--> hitbox-backend/src/response.rs:5:15
|
5 | use futures::{stream, StreamExt};
| ^^^^^^ ^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`