Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

hiveapp recompilation breaks Mobile Recharge app #3

Open
mackuba opened this issue Feb 28, 2014 · 2 comments
Open

hiveapp recompilation breaks Mobile Recharge app #3

mackuba opened this issue Feb 28, 2014 · 2 comments
Labels
Milestone

Comments

@mackuba
Copy link
Member

mackuba commented Feb 28, 2014

So that's why this is not a good idea :( Mobile recharge app apparently includes a config.js file which is not included in the repo, but generated dynamically when an app-specific build script (Gruntfile) is run to build the hiveapp. App registry just packs whatever is in the repo, so it doesn't include this file and the whole app is broken...

screen shot 2014-02-28 at 01 39 59

@mackuba mackuba added the bug label Feb 28, 2014
@weilu
Copy link
Member

weilu commented Feb 28, 2014

What about adding a downloadURL field to manifest.json? App registry only packages if downloadURL is missing

@mackuba
Copy link
Member Author

mackuba commented Feb 28, 2014

I'd say: if downloadURL is set then use it, otherwise look up the matching hiveapp on the /releases page using GitHub releases API.

@weilu weilu added this to the v1.0.0 milestone Mar 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants