Skip to content
This repository has been archived by the owner on Dec 24, 2019. It is now read-only.

Project obsolete? .spec.ttlSecondsAfterFinished can do the similar thing #16

Open
lzfxxx opened this issue Nov 20, 2018 · 6 comments
Open
Assignees

Comments

@lzfxxx
Copy link

lzfxxx commented Nov 20, 2018

What's the difference of using this CronJob from adding the .spec.ttlSecondsAfterFinished in Job config?

@hjacobs
Copy link
Owner

hjacobs commented Dec 10, 2018

This project was initially created when the mentioned feature did not exist yet, I'll have to check if kube-job-cleaner is now completely obsolete (we also still run it in our Zalando clusters).

@hjacobs
Copy link
Owner

hjacobs commented Jan 8, 2019

Apparently we can also get rid of kube-job-cleaner within Zalando with Kubernetes 1.12 and the following PR: zalando-incubator/kubernetes-on-aws#1668

@hjacobs hjacobs changed the title .spec.ttlSecondsAfterFinished can do the similar thing Project obsolete? .spec.ttlSecondsAfterFinished can do the similar thing Jan 8, 2019
@nielsole
Copy link
Contributor

nielsole commented Jan 9, 2019

while we are not yet on 1.12 we also turned kube-job-cleaner off, as the really nasty cronjobs without backoffs with restart:always and the likes have been taken care off with default values in recent releases.
Thank you very much, @hjacobs it was a pleasure :)

@hjacobs
Copy link
Owner

hjacobs commented Jan 9, 2019

@nielsole thanks! Just for reference, I think kube-job-cleaner only really becomes obsolete with the TTL setting in 1.12 to have a comparable feature, here the official KEP with all info: https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/0026-ttl-after-finish.md

@StevenACoffman
Copy link

In our continuous delivery environment, we still find it useful to run a lightly modified version of this code to clean up deployments past a certain age. Thanks! kube-deploy-cleaner

@hjacobs
Copy link
Owner

hjacobs commented Jun 27, 2019

@StevenACoffman check out my project kube-janitor to clean up arbitrary objects after some time (either with TTL annotation or custom rule for any kind of object).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants