Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomly failing test cases #234

Open
ralf-meyer opened this issue May 11, 2024 · 0 comments
Open

Randomly failing test cases #234

ralf-meyer opened this issue May 11, 2024 · 0 comments
Assignees

Comments

@ralf-meyer
Copy link
Member

ralf-meyer commented May 11, 2024

There are two test cases that cause "random" failures of the test suite

  • test_bidentate (specifically smi4)
  • test_example_7_no_FF

My guess is that for both these cases the problem comes from smiles to 3d geometry generation done using openbabel. Unfortunately, there is no way of providing a random seed (see issue #99) which leads to occasional "bad" structures and failures of the test case.

I recommend removing these until a better solution is found as these random failures of the test pipeline are extremely annoying during development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants